uecasm / colony4cc Goto Github PK

I was looking for a way to list my requests using the mod, but for some reason all the targets are UNKNOWN, i have no idea why

Havn't had a chance to play with the new health stats as I have been getting a null pointer exception when calling colony.getCitizens(). Terminal displays:
'colonyInfo.lua:26: Java Exception Thrown: java.lang.NullPointerException: null key in entry:null=net.minecraft.util.Tuple@69738c21'

The code on line 26 is just a call to that function

citizens = colony.getCitizens()

Mod Versions:
Minecolonies - 0.14.201-BETA
MineColonies for ComputerCraft - 1.2.3 (first noticed issue on 1.2.4)
Structurize 0.13.175-alpha
Forge version: 36.1.0

((Thanks so much for this very handy mod!))

Describe the bug
Requests to the colony4cc API that would return item information crash the server -- singleplayer will crash the game, multiplayer will crash the server.

Confirmed against getRequests() and getVisitorInfo() where those would return data. Empty responses do not crash the game. Other methods with non-inventory responses do not crash the game.

To Reproduce
To reproduce, call either of the named methods when item data exists.

Expected behavior
getRequests() or getVisitorInfo() returning a table containing, among other things, ItemStack information without a crash.

Versions:

• Minecraft: Forge 1.19.2-43.1.52
• Minecolonies: 1.19.2-1.0.1124
• Colony4cc: 1.19.1-2.3.1

Stack Trace:

---- Minecraft Crash Report ----
// Daisy, daisy...

Time: 2022-11-26 23:43:54
Description: Exception in server tick loop

java.lang.NoSuchMethodError: 'java.util.Map dan200.computercraft.shared.peripheral.generic.data.ItemData.fill(java.util.Map, net.minecraft.world.item.ItemStack)'
	at nz.co.mirality.colony4cc.LuaConversion$MinecraftConverter.convertStack(LuaConversion.java:130) ~[Colony4ComputerCraft-1.19.1-2.3.1.jar%23179!/:2.3.1] {re:classloading}
	at nz.co.mirality.colony4cc.LuaConversion$MinecraftConverter.convert(LuaConversion.java:81) ~[Colony4ComputerCraft-1.19.1-2.3.1.jar%23179!/:2.3.1] {re:classloading}
	at nz.co.mirality.colony4cc.LuaConversion.convert(LuaConversion.java:41) ~[Colony4ComputerCraft-1.19.1-2.3.1.jar%23179!/:2.3.1] {re:classloading}
	at nz.co.mirality.colony4cc.LuaConversion$CollectionConverter.convert(LuaConversion.java:62) ~[Colony4ComputerCraft-1.19.1-2.3.1.jar%23179!/:2.3.1] {re:classloading}
	at nz.co.mirality.colony4cc.LuaConversion.convert(LuaConversion.java:41) ~[Colony4ComputerCraft-1.19.1-2.3.1.jar%23179!/:2.3.1] {re:classloading}
	at nz.co.mirality.colony4cc.LuaConversion$CollectionConverter.lambda$convert$0(LuaConversion.java:55) ~[Colony4ComputerCraft-1.19.1-2.3.1.jar%23179!/:2.3.1] {re:classloading}
	at java.util.HashMap.forEach(Unknown Source) ~[?:?] {re:mixin}
	at nz.co.mirality.colony4cc.LuaConversion$CollectionConverter.convert(LuaConversion.java:55) ~[Colony4ComputerCraft-1.19.1-2.3.1.jar%23179!/:2.3.1] {re:classloading}
	at nz.co.mirality.colony4cc.LuaConversion.convert(LuaConversion.java:41) ~[Colony4ComputerCraft-1.19.1-2.3.1.jar%23179!/:2.3.1] {re:classloading}
	at nz.co.mirality.colony4cc.LuaConversion$CollectionConverter.convert(LuaConversion.java:62) ~[Colony4ComputerCraft-1.19.1-2.3.1.jar%23179!/:2.3.1] {re:classloading}
	at nz.co.mirality.colony4cc.LuaConversion.convert(LuaConversion.java:41) ~[Colony4ComputerCraft-1.19.1-2.3.1.jar%23179!/:2.3.1] {re:classloading}
	at nz.co.mirality.colony4cc.peripheral.ColonyPeripheral.getRequests(ColonyPeripheral.java:528) ~[Colony4ComputerCraft-1.19.1-2.3.1.jar%23179!/:2.3.1] {re:classloading}
	at nz.co.mirality.colony4cc.peripheral.ColonyPeripheral$cc$getRequests86.apply(CC generated method) ~[?:?] {re:classloading,re:classloading,re:classloading,re:classloading}
	at dan200.computercraft.core.asm.PeripheralMethod.lambda$static$0(PeripheralMethod.java:21) ~[cc-tweaked-1.19.2-1.101.1.jar%23172!/:1.101.1] {re:classloading}
	at dan200.computercraft.core.computer.LuaContext.lambda$issueMainThreadTask$0(LuaContext.java:32) ~[cc-tweaked-1.19.2-1.101.1.jar%23172!/:1.101.1] {re:classloading}
	at dan200.computercraft.core.computer.mainthread.MainThreadExecutor.execute(MainThreadExecutor.java:146) ~[cc-tweaked-1.19.2-1.101.1.jar%23172!/:1.101.1] {re:classloading}
	at dan200.computercraft.core.computer.mainthread.MainThread.tick(MainThread.java:144) ~[cc-tweaked-1.19.2-1.101.1.jar%23172!/:1.101.1] {re:classloading}
	at dan200.computercraft.shared.computer.core.ServerContext.tick(ServerContext.java:148) ~[cc-tweaked-1.19.2-1.101.1.jar%23172!/:1.101.1] {re:classloading}
	at dan200.computercraft.shared.CommonHooks.onServerTick(CommonHooks.java:56) ~[cc-tweaked-1.19.2-1.101.1.jar%23172!/:1.101.1] {re:classloading}
	at dan200.computercraft.shared.__CommonHooks_onServerTick_ServerTickEvent.invoke(.dynamic) ~[cc-tweaked-1.19.2-1.101.1.jar%23172!/:1.101.1] {re:classloading,pl:eventbus:B}
	at net.minecraftforge.eventbus.ASMEventHandler.invoke(ASMEventHandler.java:73) ~[eventbus-6.0.3.jar%2379!/:?] {}
	at net.minecraftforge.eventbus.EventBus.post(EventBus.java:315) ~[eventbus-6.0.3.jar%2379!/:?] {}
	at net.minecraftforge.eventbus.EventBus.post(EventBus.java:296) ~[eventbus-6.0.3.jar%2379!/:?] {}
	at net.minecraftforge.event.ForgeEventFactory.onPreServerTick(ForgeEventFactory.java:835) ~[forge-1.19.2-43.1.52-universal.jar%23305!/:?] {re:classloading}
	at net.minecraft.server.MinecraftServer.m_5705_(MinecraftServer.java:804) ~[client-1.19.2-20220805.130853-srg.jar%23300!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:A}
	at net.minecraft.client.server.IntegratedServer.m_5705_(IntegratedServer.java:84) ~[client-1.19.2-20220805.130853-srg.jar%23300!/:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,pl:mixin:A,pl:runtimedistcleaner:A}
	at net.minecraft.server.MinecraftServer.m_130011_(MinecraftServer.java:654) ~[client-1.19.2-20220805.130853-srg.jar%23300!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:A}
	at net.minecraft.server.MinecraftServer.m_206580_(MinecraftServer.java:244) ~[client-1.19.2-20220805.130853-srg.jar%23300!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:A}
	at java.lang.Thread.run(Unknown Source) [?:?] {}

Solar Holography and Pixie dust share the same ID. I believe this to be a mistake as id's typically are unique.

versions -
Colony4ComputerCraft-1.16.5-1.4.0
cc-tweaked-1.16.5-1.98.2
minecolonies-1.0.0-RELEASE-universal
structurize-0.13.219-ALPHA-universal

Getting a null pointer just by running colony.getPlayers()

versions -
Colony4ComputerCraft-1.16.5-1.4.0
cc-tweaked-1.16.5-1.98.2
minecolonies-1.0.0-RELEASE-universal
structurize-0.13.219-ALPHA-universal

This is spamming the console quite hard and in game, getRequests errors out due to the target being nil. I have written code to keep the program running, but the owner of the server hates the console spam.

versions -
Colony4ComputerCraft-1.16.5-1.4.0
cc-tweaked-1.16.5-1.98.2
minecolonies-1.0.0-RELEASE-universal
structurize-0.13.219-ALPHA-universal

My buddy and I run a modded server running ATM7 0.3.18 with the Minecolonies 1.18.2-1.0.636-BETA and we wanted to use the integrator to get all the minecolony we've built to be automated and easier to manage. However every time we've put in the codes it entirely crashes the server, and we also tried it for a couple other codes. Not sure whats going on and there doesn't seem to be any other issues so far here that I've seen like it

When running a script to pull status' and citizens jobs, they weren't able to be processed. They came up as a nil value. Other commands still work (age for example)

Here is the SS of the error:

here is the Line it is talking about:
mPrintRowJustified(monitor, row, "right", citizen.status, textColor)

According to the wiki, citizen.status should be the correct usage. This also applies to citizen.job.

I have only tested the string related commands so not sure if there are other ones that are coming up as nil values.

Modpack ATM 8 v1.1.0
Minecolonies 1.19.2-1.1.352-BETA.jar
Colony4CC 1.19.2-2.3.4.jar

I am not sure if this is already possible with the mod but I am curious if it would be possible to view the attributes of the visitors generated by the tavern. Thank you for your already amazing mod.

Hello,

I need exemple for view all the need ressource for buiding !
I need exemple for view all the Visitor, Citizen !
and i need exemple for view all the information of the colony !

is end !

I have setup a program capable of accepting chat commands using Advanced Peripherals mod. It would be nice to be able to check who is sending chat commands against the permissions list that Minecolonies has. A simple list of anyone that has the officer rank and the owner themselves would be great.

Describe the bug
'The Colony Peripheral' is see-through, not sure how this happens.

To Reproduce
Steps to reproduce the behavior:

1. Installed on ALL THE MODS 7 modpack (as an additional mod added afterwards)
2. Place block.
3. Observe through-block.

Expected behavior
No see-though expected!

Screenshots

Versions:

• Minecraft: 1.16.2
• Minecolonies: 1.0.893-ALPHA
• Colony4cc: 2.2.1

Additional context
No logs from the server complaining about the issue that I can see.

client crash: https://gist.github.com/eb39e0afcdc12c8ca182b7c8a4891af6
client log: https://gist.github.com/d8adcf1571892fa221c31b63e63313b0\
client debug: https://gist.github.com/679151058654585be2bdb33c59e3b75f

Forge: 1.17.1-37.0.126
Mod: 1.17.1-2.0.0

Pack Export: https://drive.google.com/file/d/18kPhNdv7fmUYvyiFUioDUt3o64o4SJu0/view?usp=drivesdk

Would be nice to be able to read the citizens health current and health totals. Seems this stat was overlooked.

Describe the bug
Unable to request RGB Charge at Minecolonies postbox

To Reproduce
Steps to reproduce the behavior:

1. Place down Postbox
2. Search RGB Charge
3. Nothing Comes up

Expected behavior
Colony4cc items to be requestable by postbox, especially since the RGB Charge is only craftable by Blacksmiths and Mechanics.

Screenshots

Versions:

• Minecraft: 1.20.1
• Minecolonies: 1.20.1-1.1.240-RELEASE
• Colony4cc: 1.20.1-2.6.0

https://user-images.githubusercontent.com/39279513/110164671-fa02a600-7df1-11eb-9dea-10ba4f114613.png
https://user-images.githubusercontent.com/39279513/110164820-333b1600-7df2-11eb-92de-fa9946ee8d9c.png

I am trying to get the required resources of the building that the builder is working on. But it returns "No Builder". I'm using minecolonies-0.13.670-ALPHA.

Trying to get the amount of materials needed using colony.getBuilderResources(). I am only getting a value of 1 for all items in the resource list using the .count value. When I check the builders table itself, it is clearly not a value of 1 on all of them.

Section of code im trying to use: [https://pastebin.com/CqmD8mjF]
I have several commented out debug lines in there where I was testing. I just cannot seem to find the proper value for count.

Describe the bug
When reading the wiki it shows that there is a 'count' property available on the item object returned by colony.getBuilderResources(), but after writing the code it was reporting 'count' was nill, after I printed the item object using textutils, I verified that 'count' indeed does not exist, 'maxCount' does, but it only contains the stack size (64 normaly)

To Reproduce
Call colony.getBuilderResources() on any builder

Expected behavior
A property called 'count' available on the item object returned by colony.getBuilderResources()

Screenshots

Versions:

• Minecraft: 1.19
• Minecolonies: 1.0.1135-ALPHA
• Colony4cc: 2.3.2

Additional Info
I've made a pastebin with my actual program to easier testing: Pastebin
Comment line 53 and decomment 50 to make it functional (created pastebin in testing mode)

Describe the bug
ColonyPeripheral.getCitizens and getVisitors does not return happiness as the signature of the method has changed.
https://github.com/ldtteam/minecolonies/blob/884f9e0ad7f3a148a94271026fb2ec29aca36665/src/api/java/com/minecolonies/api/entity/citizen/citizenhandlers/ICitizenHappinessHandler.java#L50

To Reproduce
Steps to reproduce the behavior:

1. Open A lua prompt in a computer
2. Run colony.getCitizens()
3. Game crashes (though if it didn't crash there would be no happiness)

Expected behavior
An object with happiness value should be returned

Versions:
Minecraft: 1.19.2-forge43.2.8
Minecolonies: 1.0.1351-RELEASE
Colony4cc: 2.3.3

Additional context
java.lang.NoSuchMethodError: 'double com.minecolonies.api.entity.citizen.citizenhandlers.ICitizenHappinessHandler.getHappiness(com.minecolonies.api.colony.IColony, com.minecolonies.api.colony.ICitizenData)'
at nz.co.mirality.colony4cc.peripheral.ColonyPeripheral.lambda$getCitizens$38(ColonyPeripheral.java:254) ~[Colony4ComputerCraft-1.19.2-2.3.3.jar%23324!/:2.3.3] {re:classloading}
at nz.co.mirality.colony4cc.peripheral.ColonyPeripheral.protectPut(ColonyPeripheral.java:782) ~[Colony4ComputerCraft-1.19.2-2.3.3.jar%23324!/:2.3.3] {re:classloading}
at nz.co.mirality.colony4cc.peripheral.ColonyPeripheral.getCitizens(ColonyPeripheral.java:254) ~[Colony4ComputerCraft-1.19.2-2.3.3.jar%23324!/:2.3.3] {re:classloading}
at nz.co.mirality.colony4cc.peripheral.ColonyPeripheral$cc$getCitizens1.apply(CC generated method) ~[?:?] {re:classloading,re:classloading,re:classloading,re:classloading}
at dan200.computercraft.core.asm.PeripheralMethod.lambda$static$0(PeripheralMethod.java:21) ~[cc-tweaked-1.19.2-1.101.2.jar%23317!/:1.101.2] {re:classloading}
at dan200.computercraft.core.computer.LuaContext.lambda$issueMainThreadTask$0(LuaContext.java:32) ~[cc-tweaked-1.19.2-1.101.2.jar%23317!/:1.101.2] {re:classloading}
at dan200.computercraft.core.computer.mainthread.MainThreadExecutor.execute(MainThreadExecutor.java:146) ~[cc-tweaked-1.19.2-1.101.2.jar%23317!/:1.101.2] {re:classloading}
at dan200.computercraft.core.computer.mainthread.MainThread.tick(MainThread.java:144) ~[cc-tweaked-1.19.2-1.101.2.jar%23317!/:1.101.2] {re:classloading}
at dan200.computercraft.shared.computer.core.ServerContext.tick(ServerContext.java:148) ~[cc-tweaked-1.19.2-1.101.2.jar%23317!/:1.101.2] {re:classloading}
at dan200.computercraft.shared.CommonHooks.onServerTick(CommonHooks.java:56) ~[cc-tweaked-1.19.2-1.101.2.jar%23317!/:1.101.2] {re:classloading}
at dan200.computercraft.shared.CommonHooks_onServerTick_ServerTickEvent.invoke(.dynamic) ~[cc-tweaked-1.19.2-1.101.2.jar%23317!/:1.101.2] {re:classloading,pl:eventbus:B}
at net.minecraftforge.eventbus.ASMEventHandler.invoke(ASMEventHandler.java:73) ~[eventbus-6.0.3.jar%2385!/:?] {}
at net.minecraftforge.eventbus.EventBus.post(EventBus.java:315) ~[eventbus-6.0.3.jar%2385!/:?] {}
at net.minecraftforge.eventbus.EventBus.post(EventBus.java:296) ~[eventbus-6.0.3.jar%2385!/:?] {}
at net.minecraftforge.event.ForgeEventFactory.onPreServerTick(ForgeEventFactory.java:835) ~[forge-1.19.2-43.2.8-universal.jar%23440!/:?] {re:classloading}
at net.minecraft.server.MinecraftServer.m_5705(MinecraftServer.java:804) ~[client-1.19.2-20220805.130853-srg.jar%23435!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:A}
at net.minecraft.client.server.IntegratedServer.m_5705(IntegratedServer.java:84) ~[client-1.19.2-20220805.130853-srg.jar%23435!/:?] {re:classloading,pl:runtimedistcleaner:A}
at net.minecraft.server.MinecraftServer.m_130011_(MinecraftServer.java:654) ~[client-1.19.2-20220805.130853-srg.jar%23435!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:A}
at net.minecraft.server.MinecraftServer.m_206580_(MinecraftServer.java:244) ~[client-1.19.2-20220805.130853-srg.jar%23435!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:A}
at java.lang.Thread.run(Thread.java:833) [?:?] {}

Describe the bug
Whem Supplementaries and Alexis Caves installed game crash on world load/creation.

To Reproduce
Steps to reproduce the behavior:
install mods:

boot minecraft
create new world

Expected behavior
World load

Actual behavior
MInecraft crash

Logs
latest.log
crash-2023-12-01_15.17.08-server.txt

Hi.

When trying to run getRequests on a server I'm getting the following error:

[11:11:00] [Server thread/FATAL] [ne.mi.fm.lo.RuntimeDistCleaner/DISTXFORM]: Attempted to load class net/minecraft/client/gui/screen/Screen for invalid dist DEDICATED_SERVER
[11:11:00] [Server thread/ERROR] [computercraft/]: Error running task
java.lang.RuntimeException: Attempted to load class net/minecraft/client/gui/screen/Screen for invalid dist DEDICATED_SERVER
at net.minecraftforge.fml.loading.RuntimeDistCleaner.processClassWithFlags(RuntimeDistCleaner.java:71) ~[forge-1.16.5-36.1.23.jar:36.1] {}
at cpw.mods.modlauncher.LaunchPluginHandler.offerClassNodeToPlugins(LaunchPluginHandler.java:85) ~[modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.ClassTransformer.transform(ClassTransformer.java:120) ~[modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.TransformingClassLoader$DelegatedClassLoader.findClass(TransformingClassLoader.java:265) ~[modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.TransformingClassLoader.loadClass(TransformingClassLoader.java:136) ~[modlauncher-8.0.9.jar:?] {re:classloading}
at cpw.mods.modlauncher.TransformingClassLoader.loadClass(TransformingClassLoader.java:98) ~[modlauncher-8.0.9.jar:?] {re:classloading}
at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.8.0_291] {}
at com.buuz135.industrial.item.infinity.ItemInfinity.getDurabilityForDisplay(ItemInfinity.java:198) ~[industrialforegoing:3.2.11] {re:classloading}
at dan200.computercraft.shared.peripheral.generic.data.ItemData.fill(ItemData.java:66) ~[computercraft:1.95.3] {re:classloading}
at nz.co.mirality.colony4cc.LuaConversion$MinecraftConverter.convertStack(LuaConversion.java:123) ~[colony4cc:1.2.1] {re:classloading}
at nz.co.mirality.colony4cc.LuaConversion$MinecraftConverter.convert(LuaConversion.java:77) ~[colony4cc:1.2.1] {re:classloading}
at nz.co.mirality.colony4cc.LuaConversion.convert(LuaConversion.java:37) ~[colony4cc:1.2.1] {re:classloading}
at nz.co.mirality.colony4cc.LuaConversion$CollectionConverter.convert(LuaConversion.java:58) ~[colony4cc:1.2.1] {re:classloading}
at nz.co.mirality.colony4cc.LuaConversion.convert(LuaConversion.java:37) ~[colony4cc:1.2.1] {re:classloading}
at nz.co.mirality.colony4cc.LuaConversion$CollectionConverter.lambda$convert$0(LuaConversion.java:51) ~[colony4cc:1.2.1] {re:classloading}
at java.util.HashMap.forEach(Unknown Source) ~[?:1.8.0_291] {}
at nz.co.mirality.colony4cc.LuaConversion$CollectionConverter.convert(LuaConversion.java:51) ~[colony4cc:1.2.1] {re:classloading}
at nz.co.mirality.colony4cc.LuaConversion.convert(LuaConversion.java:37) ~[colony4cc:1.2.1] {re:classloading}
at nz.co.mirality.colony4cc.LuaConversion$CollectionConverter.convert(LuaConversion.java:58) ~[colony4cc:1.2.1] {re:classloading}
at nz.co.mirality.colony4cc.LuaConversion.convert(LuaConversion.java:37) ~[colony4cc:1.2.1] {re:classloading}
at nz.co.mirality.colony4cc.peripheral.ColonyPeripheral.getRequests(ColonyPeripheral.java:368) ~[colony4cc:1.2.1] {re:classloading}
at nz.co.mirality.colony4cc.peripheral.ColonyPeripheral$cc$getRequests20.apply(CC generated method) ~[?:?] {re:classloading,re:classloading,re:classloading,re:classloading,re:classloading,re:classloading,re:classloading,re:classloading}
at dan200.computercraft.core.asm.PeripheralMethod.lambda$null$0(PeripheralMethod.java:21) ~[computercraft:1.95.3] {re:classloading}
at dan200.computercraft.core.lua.CobaltLuaMachine$CobaltLuaContext.lambda$issueMainThreadTask$0(CobaltLuaMachine.java:522) ~[computercraft:1.95.3] {re:classloading}
at dan200.computercraft.core.computer.MainThreadExecutor.execute(MainThreadExecutor.java:143) ~[computercraft:1.95.3] {re:classloading}
at dan200.computercraft.core.computer.MainThread.executePendingTasks(MainThread.java:157) ~[computercraft:1.95.3] {re:classloading}
at dan200.computercraft.shared.proxy.ComputerCraftProxyCommon$ForgeHandlers.onServerTick(ComputerCraftProxyCommon.java:121) ~[computercraft:1.95.3] {re:classloading}
at net.minecraftforge.eventbus.ASMEventHandler_659_ForgeHandlers_onServerTick_ServerTickEvent.invoke(.dynamic) ~[?:?] {}
at net.minecraftforge.eventbus.ASMEventHandler.invoke(ASMEventHandler.java:85) ~[eventbus-4.0.0.jar:?] {}
at net.minecraftforge.eventbus.EventBus.post(EventBus.java:302) ~[eventbus-4.0.0.jar:?] {}
at net.minecraftforge.eventbus.EventBus.post(EventBus.java:283) ~[eventbus-4.0.0.jar:?] {}
at net.minecraftforge.fml.hooks.BasicEventHooks.onPreServerTick(BasicEventHooks.java:115) ~[forge:?] {re:classloading}
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:785) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:structure_gel.mixins.json:MinecraftServerMixin,pl:mixin:APP:jaopca.mixins.json:MinecraftServerMixin,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.server.MinecraftServer.func_240802_v_(MinecraftServer.java:642) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:structure_gel.mixins.json:MinecraftServerMixin,pl:mixin:APP:jaopca.mixins.json:MinecraftServerMixin,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.server.MinecraftServer.func_240783_a_(MinecraftServer.java:232) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:structure_gel.mixins.json:MinecraftServerMixin,pl:mixin:APP:jaopca.mixins.json:MinecraftServerMixin,pl:mixin:A,pl:runtimedistcleaner:A}
at java.lang.Thread.run(Unknown Source) [?:1.8.0_291] {}

Thanks

Describe the bug
Any method to get resources crushes game

To Reproduce
Steps to reproduce the behavior:

1. Create clear wolrd (I used plain)
2. Create a colony
3. Claim Town Hall
4. Claim Builder's Hut
5. Give spade to builder (to complete all NPC's requests)
6. Build a computer with monitor
7. Try to request resources with getWorkOrderResources or getBuilderResources

So I have 2 plans: Town Hall and Builder's Hut. Only plans, no buildings. And I ordered Builder's Hut to start building, so NPCs created build requests

My code example:

local monitor = peripheral.wrap("top")

monitor.clear()

local orders = colony.getWorkOrders();
local row = 1

monitor.setCursorPos(1, row);

for i=1, #orders do
	local order = orders[i]
	
	if order.type=="building" then
		row = i + row
		monitor.setCursorPos(0, row)
	
		monitor.write(" | " .. order.type .. " | " .. order.claimedByBuilding.x .. " | " .. order.claimedByBuilding.y .. " | " .. order.claimedByBuilding.z .. " |")
		
		local resources = colony.getWorkOrderResources(order.id)
	end	
end

Expected behavior
resources = colony.getWorkOrderResources(order.id) should return table of resources (but it just crushes game)

Versions:

• Minecraft: 1.20.1
• Minecolonies: 1.1.461-BETA
• Colony4cc: 2.6.2

Additional context
crash-2024-02-14_02.32.35-server.txt
luaCode.txt

When building a new mod pack I tried to use this mod but ran into a "version conflict that was incorrect. This could be a "locked" version, or could be due to BETA release and there is no full release. Please see "steps to reproduce below" for details.

To Reproduce
Steps to reproduce the behavior:

1. Create a new profile in your favorite launcher
2. load up minecraft 1.19.2 and forge 43.3.0
3. Add the minecolonies mod, latest version (1.19.2-1.1.516-BETA) as of this submission
4. Add the MineColonies for Computer craft, latest version (2.3.6), as of this submission.
5. Try to launch the pack and get "colony4cc requires minecolonies version 1.19.2-1.1.465-RELEASE or above

Expected behavior
RELEASE VS BETA seems to be the issue but expected behavior is to allow the game to load.

Screenshots

When this mod is installed, modded banner patterns no longer work as a colony banner (or at least the patterns from Ice and Fire, that is the only mod I have installed that adds patterns). The patterns still appear on the list but they all just a line at the bottom

.

Describe the bug
A clear and concise description of what the bug is.

ColonyPeripheral.protectPut does not protect against java.lang.NoSuchMethodError as it does not inherit from Exception.
https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/NoSuchMethodError.html

not to be confused with java.lang.NoSuchMethodException, which does, but is not thrown in this case
https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/NoSuchMethodException.html

To Reproduce
Steps to reproduce the behavior:

1. Open A lua prompt in a computer
2. Run colony.getCitizens()
3. Game crashes

Expected behavior
An error should be printed to the log

Versions:

• Minecraft: 1.19.2-forge43.2.8
• Minecolonies: 1.0.1351-RELEASE
• Colony4cc: 2.3.3

Additional context
java.lang.NoSuchMethodError: 'double com.minecolonies.api.entity.citizen.citizenhandlers.ICitizenHappinessHandler.getHappiness(com.minecolonies.api.colony.IColony, com.minecolonies.api.colony.ICitizenData)'
at nz.co.mirality.colony4cc.peripheral.ColonyPeripheral.lambda$getCitizens$38(ColonyPeripheral.java:254) ~[Colony4ComputerCraft-1.19.2-2.3.3.jar%23324!/:2.3.3] {re:classloading}
at nz.co.mirality.colony4cc.peripheral.ColonyPeripheral.protectPut(ColonyPeripheral.java:782) ~[Colony4ComputerCraft-1.19.2-2.3.3.jar%23324!/:2.3.3] {re:classloading}
at nz.co.mirality.colony4cc.peripheral.ColonyPeripheral.getCitizens(ColonyPeripheral.java:254) ~[Colony4ComputerCraft-1.19.2-2.3.3.jar%23324!/:2.3.3] {re:classloading}
at nz.co.mirality.colony4cc.peripheral.ColonyPeripheral$cc$getCitizens1.apply(CC generated method) ~[?:?] {re:classloading,re:classloading,re:classloading,re:classloading}
at dan200.computercraft.core.asm.PeripheralMethod.lambda$static$0(PeripheralMethod.java:21) ~[cc-tweaked-1.19.2-1.101.2.jar%23317!/:1.101.2] {re:classloading}
at dan200.computercraft.core.computer.LuaContext.lambda$issueMainThreadTask$0(LuaContext.java:32) ~[cc-tweaked-1.19.2-1.101.2.jar%23317!/:1.101.2] {re:classloading}
at dan200.computercraft.core.computer.mainthread.MainThreadExecutor.execute(MainThreadExecutor.java:146) ~[cc-tweaked-1.19.2-1.101.2.jar%23317!/:1.101.2] {re:classloading}
at dan200.computercraft.core.computer.mainthread.MainThread.tick(MainThread.java:144) ~[cc-tweaked-1.19.2-1.101.2.jar%23317!/:1.101.2] {re:classloading}
at dan200.computercraft.shared.computer.core.ServerContext.tick(ServerContext.java:148) ~[cc-tweaked-1.19.2-1.101.2.jar%23317!/:1.101.2] {re:classloading}
at dan200.computercraft.shared.CommonHooks.onServerTick(CommonHooks.java:56) ~[cc-tweaked-1.19.2-1.101.2.jar%23317!/:1.101.2] {re:classloading}
at dan200.computercraft.shared.CommonHooks_onServerTick_ServerTickEvent.invoke(.dynamic) ~[cc-tweaked-1.19.2-1.101.2.jar%23317!/:1.101.2] {re:classloading,pl:eventbus:B}
at net.minecraftforge.eventbus.ASMEventHandler.invoke(ASMEventHandler.java:73) ~[eventbus-6.0.3.jar%2385!/:?] {}
at net.minecraftforge.eventbus.EventBus.post(EventBus.java:315) ~[eventbus-6.0.3.jar%2385!/:?] {}
at net.minecraftforge.eventbus.EventBus.post(EventBus.java:296) ~[eventbus-6.0.3.jar%2385!/:?] {}
at net.minecraftforge.event.ForgeEventFactory.onPreServerTick(ForgeEventFactory.java:835) ~[forge-1.19.2-43.2.8-universal.jar%23440!/:?] {re:classloading}
at net.minecraft.server.MinecraftServer.m_5705(MinecraftServer.java:804) ~[client-1.19.2-20220805.130853-srg.jar%23435!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:A}
at net.minecraft.client.server.IntegratedServer.m_5705(IntegratedServer.java:84) ~[client-1.19.2-20220805.130853-srg.jar%23435!/:?] {re:classloading,pl:runtimedistcleaner:A}
at net.minecraft.server.MinecraftServer.m_130011_(MinecraftServer.java:654) ~[client-1.19.2-20220805.130853-srg.jar%23435!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:A}
at net.minecraft.server.MinecraftServer.m_206580_(MinecraftServer.java:244) ~[client-1.19.2-20220805.130853-srg.jar%23435!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:A}
at java.lang.Thread.run(Thread.java:833) [?:?] {}

Describe the bug

• I go to lua, type colony.getInfo(), the game crashed with error
  Error: java.lang.NoSuchMethodError: 'java.lang.String com.minecolonies.api.colony.IColony.getStyle()'

To Reproduce
Steps to reproduce the behavior:

1. place down townhall and setup colonies peripherals with a cc computer
2. create new town
3. turn on cc computer, lua, and try colony.getInfo()
4. the game/server shutdown

Expected behavior
should give out the info of the colony

Screenshots
If applicable, add screenshots to help explain your problem.

Versions:

• Minecraft: 1.19.1, forge 42.0.9
• Minecolonies: 1.19.2-1.0.
• Colony4cc: 1.19.1-2.3.0.jar

Additional context
Add any other context about the problem here.
Include logs (from a paste site like gist) if appropriate.
crash-2022-09-11_22.43.15-server.txt

the families features in the newest version of minecolonies refactored mourning to apply to families only instead of to the whole colony. It removed colony.isMourning which colony4cc is still trying to call.