ueberdosis / hocuspocus-laravel Goto Github PK

I wondered if there was a reason not to use the built-in session for authentication of requests rather than custom tokens. The session id could be sent with the request the same way the access token currently is, however it would provide a number of advantages over the current access token system:

• Built in expiry - access tokens currently don't expire which is a security risk
• Automatic integration with Laravel's auth system without needing extra tables, classes
• Considerably less code to maintain in the plugin

@hanspagel what is with PHP 8 support on this package? As new as it is, it should work, or are there any known issues? 😕

New documents need a good default:

[ 'type' => 'doc', 'content' => [], ]

But that would only work for tiptap?

Or maybe better shouldn’t fail like that:

Attaching to mailmaker_hocuspocus_1
hocuspocus_1  | [2021-05-05T15:14:52.962Z] Server configured …
hocuspocus_1  | [2021-05-05T15:14:52.965Z] Listening on port "80" …
hocuspocus_1  | [2021-05-05T15:15:22.160Z] Upgrading connection …
hocuspocus_1  | [2021-05-05T15:15:22.174Z] New connection to "App%5CModels%5CNewsletter%3A1" …
hocuspocus_1  | [2021-05-05T15:15:23.592Z] Created document "App%5CModels%5CNewsletter%3A1" …
hocuspocus_1  | /var/www/node_modules/prosemirror-model/dist/index.js:1368
hocuspocus_1  |   if (!json) { throw new RangeError("Invalid input for Node.fromJSON") }

• Add a command to generate a secret key
• Add the HocuspocusProvider to the README
• Throw an error when the configured attributes aren’t present