udacity / frontend-grading-engine Goto Github PK

View Code? Open in Web Editor NEW

132.0 46.0 172.0 2.23 MB

Providing immediate feedback for front-end code

License: MIT License

HTML 2.61% JavaScript 95.42% CSS 1.97%

frontend-grading-engine's Issues

Firefox: Lesson 3.5 Udacity Feedback Not Working

The linked JSON page isn’t at the same origin and directory as the document.

I was searching all over the place for an answer. I'm running 57.0.4 (64-bit).

Instead of automatically working, what you have to do is:

Navigate to http://udacity.github.io/fend/fend-refresh/lesson2/problem-set/headers/tests.json
Click save
Save to the directory in the same folder as index.html
Using your text editor, for the meta tag named udacity-grader, change the content value to tests.json
The grader should now work!

It should not be this cumbersome, but if this is the way it was intended, please include a tutorial!

Not working for FEND 13.6

I was just working in a prior lesson and the Udacity Feedback extension / grader was working. Got to this lesson, opened the link, and no extension. (The extension icon is in my Chrome browser.) The page loads, but the grader never loads.

add unit tests against the GE

Self-explanatory. Regression testing is awesome but I'd like something more granular too.

Test not being evaluated correctly [Chrome 63]

The test I am referring to is at http://udacity.github.io/fend/lessons/L3/problem-set/08-udacity-site-header/index.html.
No matter what you try, you can't pass the "The font-weight of the header text is 400" test on Chrome 63.
This seems to be a bug as it works on older Chrome versions.

Oversized Main Div

On the chrome extension, the main div for the popup is bigger than the body, creating an ugly scroll bar. See the screenshot:

I can help fix this with a quick patch if there's no particular reason why the div width should be fixed at 800px!

No Feedback Code

The extension is not providing me a code to paste into the classroom, anyone else encounter this too?

Support Add-on SDK

We need to support the 2 last versions of a Web Browser. Since Firefox is planning to fully support WebExtensions in 2 years, we need to use the Add-on SDK as a fallback/temporary solution.

Set the test-widget (iframe) height according to its content height

Using an iFrame instead of WebComponents for the test-widget introduced an unexpected behaviour, namely:

The Height of the test-widget window can only be fixed. It can't grow as content is added in the iFrame. The workaround I found is to calculate the iFrame window's height and pass it to the test-widget container. However, it doesn't seem to work when listening for DOMContentLoaded because when an iFrame is created, it also create a dummy document. It may be possible to emulate that event with a MutationListener.

hi

I need help

check the JSON is not from cache

In firefox, when we refresh the page, the cached JSON test file is used instead of downloading it again.

emit event when a test passes

I'm getting requests for insight into when tests pass. We want to build sites that are also able react to tests passing (eg. changing text color, CSS, to give additional indication that tests pass). Let's add a defined test and suite pass event API.

warn students that zooming their browsers will affect test results

I've seen some complaints that zooming prevents tests from passing, especially when tests are related to any kind of pixel calculation. Let's consider adding a feature where we warn students to stay at 100% zoom so that tests pass.

The alternative is to actually account for zoom with pixel calculations. My intuition is that this is more trouble than its worth, but I could be wrong.

make the Safari wrapper a library

To increase modularity and its functionalities, it might be interesting to make a library out of the Safari wrapper. From my knowledge, it's the most complete WebExtensions wrapper for Safari available.

We could also make it a NPM task that will inject the needed functionalities of an extension to work on Safari.

Udacity Feedback: Tree to HTML Quiz Test Results

For such a simple quiz, I am unable to pass/understand this quiz's requirements. I've tried saving in different formats, recreating the files, and even using different IDEs. Am I missing something here?

My code:

<!DOCTYPE html>
<html lang="en">
<head>
  <meta charset="UTF-8">
  <title>Tree to HTML</title>
  <!-- the next line loads the tests for the Udacity Feedback extension -->
  <meta name="udacity-grader" content="http://udacity.github.io/fend/fend-refresh/lesson2/problem-set/tree-to-html/tests.json">
</head>
<body>
  <h1>This is my header</h1>
    <div
      <p>Here is my first paragraph.</p>
      <p>Here is my second paragraph.</p>
    </div>
</body>
</html>

The error reported:
X Paragraphs have content

Criteria code:

"description": "Paragraphs have content",
      "definition": {
        "nodes": "p",
        "get": "innerHTML",
        "hasSubstring": ".+"

Lesson 3 - Make all the headers

Hi everybody :) I am very new to all of this and I am stuck with this lesson 3 - make all the headers as I don't understand where I can put my practice code for h1-h4. I've downloaded the Udacity Feedback extension and the Headers file but I am not sure where to get a necessary code to finish a test?

add warning in Chrome when using `file://`

Previously, there was a warning in Chrome about using the extension with the file:// scheme. Chrome doesn't support loading files from that scheme using XMLHttpRequest. Also, since the file input doesn't work anymore ( #21 ), it was a noisy warning I decided to remove.

Actually there may be a workaround by using the filesystem API, but injecting it might be much more complicated.

getting shorthand or used value css property may result in a test failing

When using the window.getComputedStyle method to get a CSS value, it may not return the actual value. Depending on the browser implementation, the browser can return an empty String or a deliberately wrong value (for security in that case).

As an example, getting the padding shorthand CSS property in Firefox will fail because it complies to the CSS specifications (surprisingly Chrome doesn't).

It might be worth complying to the various browser implementations. See https://developer.mozilla.org/en-US/docs/Web/CSS/used_value#Difference_from_computed_values

verify that the linked JSON file has a good origin before initializing the Engine

When an origin is whitelisted, but doesn't have a valid origin for the JSON file, it initializes the Grading Engine even though nothing is loaded. Should we consider not initializing the Engine before testing having a JSON file?

Font sizing is affected by body

Noticed by @jamesparkes: if you set font-size for the body, it also affects the font-size of the text in the feedback widget. it might be worth giving the text in the widget some default styling

Udacity feedback: FEWD Google Challenge Lesson 3: HTML Syntax Problem Set Make a List Solution is Incorrect

The instructions ask for an unordered list but the solution shows an ordered list.

Instructions
I want you to: (Look! Another unordered list!) Add an unordered list element with three child elements (one each for HTML, CSS, and JavaScript).

Correct answer
`

Create an unordered list! Make a list of the three web languages: HTML, CSS and JavaScript.

HTML
CSS
JavaScript

Provided solution
`

Any time you see a sequence of similar objects in a web site, it's probably a list. That goes for lists of articles on your favorite news app as well as things like videos on YouTube or Netflix.

HTML
CSS
JavaScript

Thank you!

Udacity Feedback Extension not recognize font awesome icon

Hi team, thanks for providing Responsive Images as a good course for me. It's a good thing that web developer should care about images, typography when develop website. When I'm using fontawesome to get facebook, twitter, google+, and digg, the Udacity feedback extension doesn't respons it (I have refresh it several times in Google Chrome browser). This is the screenshot:

This is the Gist Code

But, when I see your project-2 solution, it use the We Love Font Icons website as the provider font icon. Why only this website can recognized by Udacity feedback extension? I think it should be fix it, so that's not only We Love Font Icons but Font awesome and other font icons website can recognized by Udacity feedback extension. Thank you very much.

P.S. I have give this issue on responsive-images repository. I give this issue on this repo to get your fast response answer.

Not able to download Json

I am not able download a json file. When I save a file in atom it saves as an HTML and wont let me save as json to use the udacity feedback tool. I am missing something?

implement em, rem, % units

Given that:

Getting a CSS property using the window.getComputedStyle method will only give sizes as pixel unit.
Quizzes will ask for a relative unit size.
Browser/OS styles will vary and may result in a different absolute unit.

We should implement a function to calculate the computed value in different units.

add a last child selector

On tests that need to select the last child element, a fixed children number is usually used. If someone adds an element before the last child, it may mark the test as incorrect.

Why are source files placed in two places?

In the repository, there are two places where source files are placed:

src/
ext/src/

Given that we use a building tool, shouldn't we use only one directory to make the extension? It's much easier to maintain.

kitten

.kitten-image{
        border: 5px dashed #fa8072;
        border-radius: 5px;
        box-shadow: 5px 5px 20px rgb(204,204,204);
        cursor: pointer;

loading JSON with file input not working

Loading a JSON local file from the file input doesn't seem to work. It should work even when a website is not whitelisted to allow testing arbitrary websites. Otherwise, someone would always see the widget (with "No tests loaded") when browsing on the website.

Turn Feedback On

In Quiz 5, Make All the Headers, I don't know how to turn the feedback on when I load my website. I created the code and see the language. Please provide solutions.

Udacity Feedback Extension not working on Firefox

On Firefox, there is a problem getting a code for solving Project 2, part 2 (Lesson 8.14) and Lesson 9.10 (quiz). It works in Chrome but when running the Udacity Feedback Extension in Firefox, I get this error in red: The linked JSON page isn’t at the same origin and directory as the document. If you look at the ratings of the Udacity extension on Firefox, apparently this has been an issue for a while.

chrome-extension://keffdhbdajnlclhjikaagcmkcbmfmojm/app/js/libs/GE.js Failed to load resource: net::ERR_FILE_NOT_FOUND

udacity / frontend-grading-engine Goto Github PK

frontend-grading-engine's Issues

Recommend Projects

Recommend Topics

Recommend Org