Git Product home page Git Product logo

coordconv's People

Contributors

mimosavvy avatar rquber avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

coordconv's Issues

CoordConv position for a2c

Hi,

I'm wondering where exactly did you put a coordconv layer for a2c algorithm. Is it before the input?
The paper states 'Adding a CoordConv layer to an actor network within A2C', does this mean the critic network does not use coordconv? but actor and critic network share parameters.

Thanks

Cannot reproduce results of "coordconv_rendering" task

I get zero accuracies by running the instructed command:

# coordconv version
python train.py --arch coordconv_rendering -mb 16 -E 100 -L 0.005 --opt adam --l2 0.001 -mul 1 --use_mse_loss

I am using the instructed tensorflow 1.14 environment as well.
Since there are obvious runtime errors (e.g., variable not declared here and here), I suspect the codes are released without even testing if the codes runnable (not to mention the numbers in the paper).

Can the authors make some clarifications on what is the status of this repo?

Wrong denominators when normalize xx_channel and yy_channel?

Hi, in your code you normalize xx_channel and yy_channel as following:

xx_channel = tf.cast(xx_channel, 'float32') / (self.x_dim - 1)

yy_channel = tf.cast(yy_channel, 'float32') / (self.y_dim - 1)

I think it should be:
xx_channel = tf.cast(xx_channel, 'float32') / (self.y_dim - 1)
yy_channel = tf.cast(yy_channel, 'float32') / (self.x_dim - 1)
That is the denominators are wrong?

Python3 Compatibility

Hi,
This is a very minor issue--nevertheless, the rest of the repository working, I really wanted to have this fixed.
This repository code at generating data is not python3 compatible.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.