Git Product home page Git Product logo

2015-02-12-warehouse-web's Issues

Feedback

Can you make this method work with an options hash?

https://github.com/uanwar88/2015-02-12-warehouse-web/blob/master/main.rb#L26


Best practice is to set variables when possible in the route handler and then use them in views.

E.g. @categories = Category.list_all and then using @categories in https://github.com/uanwar88/2015-02-12-warehouse-web/blob/master/views/del_cat_loc.slim#L12


No database methods module? Also, your methods mostly return the array of hashes from the database โ€“ as opposed to returning an array of objects. I'd like to see demonstration of this at least in 2-3 places before you move on to the project.


Tests?


Documentation is missing entirely (Well, not entirely ๐Ÿ˜„ โ€“ but close!).

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.