typesettingtools / ffi-experiments Goto Github PK

On recent GHA Windows runners, the libcurl wrap picks up zlib and libSSH2, and dynamically links against them. The resulting DLL will then fail to be loaded by LuaJIT on any machine that doesn't have these libraries installed.

Unfortunately, there's no working CI build of ffi-experiments that's still preserved, but the "Generate Windows Installer" step in the following two Aegisub builds also show this:

• Good: https://github.com/arch1t3cht/Aegisub/actions/runs/3510878855
  Logs also archived here: logs_53.zip
• Bad: https://github.com/arch1t3cht/Aegisub/actions/runs/3543940997
  Logs also archived here: logs_54.zip

Disabling zlib and SSH2 support in curl via CMake options (see arch1t3cht@2618e45) solves this, though there might be some better and more general solution that just disables or hides all these optional dependencies.

https://curl.haxx.se/libcurl/c/CURLOPT_TIMEOUT.html

Currently, in a scenario with an unstable connection and Linux, we can hang for a very long time. We should consider a specific-duration timeout, depending on the size of the downloaded files, and also potentially thread it through the API and make it user-configurable.

They have the same name, and as DownloadManager ends up being dynamically linked to libcrypto.so, the OpenSSL function will be called instead, resulting in a segfault due to differing function signatures.