Improvement request

Module: core, praytimes, hijri

Description: Make more support for Functional Prorgamming Style

Request details:

The project needs more support for functional programming style that Kotlin provides

Example:

OOP style

val config = PrayerTimesCalculator.Config(
    calcMethod = CalculationMethod.EGYPT
    asrMethod = AsrMethod.SHAFII
    offsets = PrayerTimesOffsets(
       fajr = 10
       maghrib = 2
    )
)

Functional Programming style

val config = prayerTimesCalcConfig (
    calcMethod = CalculationMethod.EGYPT
    asrMethod = AsrMethod.SHAFII
    offsets = prayerTimesOffsets {
       fajr = 10
       maghrib = 2
    }
}

Improvement request

Module: core

Description: Create a json file placed in resources that contains large set of locations grouped by country code

Request details:

Example

{
    "EG": {
        "name": "Egypt",
        "cities": {
            "Cairo": {
                "lat": 30.125154578,
                "lng": 31.264545548,
                "tz": 2.0
            },
        }
    },
}

Create Qibla module

Improvement request

Module: core
Sub-module: location

Description: Add more cities to PopularLocations

Request details:

Add more popular cities and locations usually used by users such as: Makkah

This issue is open for contributions from other developers to cover a large set of locations

Bug report

Module: prayertimes

Description: PrayerTimes.current returns same value as PrayerTimes.next

Bug details:

If we have a piece of code like:

val prays = PrayerTimes.getTodayPrays(loc, config)
val currentPray = prays.current
val nextPray = prays.next

// Let's assume that actual current pray is Asr and next pray is Maghrib

print(currentPray.type) // prints: MAGHRIB
print(nextPray.type) // prints: MAGHRIB

it prints the next pray not the current pray as I performed a test but found that both field getters return the same pray

Improvement request

Module: core

Description: Remove countries subcalsses and add more cities in PopularLocaitons

Request details:

I assume getting Cairo location from PopularLocations so, instead of calling it this way:

val cairo = PopularLocations.Egypt.CAIRO

it will be this way for more smooth calling:

val cairo = PopularLocations.Cairo

Help wanted here