tyler-technologies-oss / eslint-rules Goto Github PK

Fix the PR versioning. Currently don't know how to tag itself and properly versions PR commits.

My team and I currently under the process of upgrading to Angular 18 for all our apps. I have found an issue potentially related to @tylertech-eslint packages:

1. "@tylertech-eslint/eslint-plugin": "1.0.12"
2. "@tylertech-eslint/eslint-plugin-angular": "1.0.12"
3. "@tylertech-eslint/eslint-plugin-angular-template": "1.0.12"

The errors are as follow:

I tried to downgrade typescript to 5.2.0 but receive the following error:

Angular 18 required typescript version higher than 5.2.0.

The reason why I think there is a potential issue with the @tylertech-eslint package is due to its dependency of @typescript-eslint/experimental-utils:

When I looked up this package: @typescript-eslint/experimental-utils - npm (npmjs.com), it telling me that is recommend to switch to the permanent long term support package @typescript-eslint/utils: @typescript-eslint/utils - npm (npmjs.com)

Is it possible to upgrade the @tylertech-eslint npm packages and its dependency so it can be use with Angular 18 and higher typescript version? It is currently a critical issue for us. If in case that I am wrong in the direction of the issue please let me know. Thanks!

When renaming members to _memberName, does not fix references in the file.

When adding private accessor keyword, does not check if public is already there. Should remove public

It looks like there might be some dependency leakage from the eslint-plugin-angular and eslint-plugin-angular-template projects.
They both have a dependency on gulp instead of a devDependency, causing projects referencing this to get cited by Dependabot for a security vulnerability in one of gulp's dependencies.

Branch protection should be enabled for this repository. I can set that up for you. It looks like this repository does not have an admin-level team configured. Add a comment with the following text to add a team and apply branch protection:

/admin-teams my-team
/protect

If this repository is not meant to have branch protection (not recommended), comment with /ignore and I'll close the issue and stop bothering you.

If you will be configuring branch protection yourself you can ignore this issue. I'll close it the next time I check this repository.

See this for a full list of commands.