Git Product home page Git Product logo

feature-propagation's People

Contributors

emalgorithm avatar willnorris avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

feature-propagation's Issues

Possible Non-Square Adjacency Matrix

If the edge index somehow does not include the last row or column of the adjacency matrix, the torch.sparse.FloatTensor() may not keep the full dimensionality of the matrix which later will result in error.
Change line 39 in feature_propagation.py
adj = torch.sparse.FloatTensor(edge_index, values=edge_weight).to(edge_index.device)
into
adj = torch.sparse.FloatTensor(edge_index, edge_weight,(n_nodes, n_nodes)).to(edge_index.device)

edge_weight is overriden in FeaturePropagation

In the method get_propagation_matrix of the class FeaturePropagation the variable edge_weight is overriden in the following code:

edge_weight = edge_weight if edge_weight else torch.ones(edge_index.shape[1]).to(edge_index.device)
edge_index, edge_weight = get_symmetrically_normalized_adjacency(edge_index, n_nodes=n_nodes)

Since in the function get_symmetrically_normalized_adjacency all weights are defined as 1, this code essentially makes the graph unweighted.

About the results in table 2.

image
I read your amazing paper “ On the Unreasonable Effectiveness of Feature Propagation in Learning on Graphs with Missing Node Features ”。 But I have questions about the results of Label Prop on Citeseer: I tuned hyperparameters but can't achieve 64.6 (I can only achieve 45 or so). Could you share the code or tell me where the results are from? Also, What is the Pos Enc method.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.