Git Product home page Git Product logo

Comments (6)

Twinside avatar Twinside commented on July 18, 2024

All visual rendering must be accurate to within one device pixel (px unit) to
the mathematically correct result at the initial 1:1 zoom ratio. It is suggested
that viewers attempt to keep a high degree of accuracy when zooming.

and

Both a Conforming High-Quality Static SVG Viewer and a Conforming
High-Quality Dynamic SVG Viewer must support the following additional
features:
...
At least double-precision floating point computation on coordinate system
transformation numerical calculations.

SkScalar of SKIA, the Chrome rendering library, which use float in it's pipeline.

Simply put, for rendering, float precision is sufficient. Thus said, holding all the geometry and transformation can be put in double, if it can open more use of the library. But changing the type of the drawing attributes hold literally no value.

And what is more problematic for me, it's a major change forcing a bump to a 0.3 version, that will force me to update rasterific-svg . I'm willing to accept a patch, if only transformation/geometry is switched to doubles.

from svg-tree.

kasbah avatar kasbah commented on July 18, 2024

What about _strokeWidth :: Number? That's a drawing attribute but is it OK to switch that to using Double since all the transformation/geometry uses the Number type as well?

from svg-tree.

Twinside avatar Twinside commented on July 18, 2024

I think we can, let's just keep only the color stuff with Float

from svg-tree.

kasbah avatar kasbah commented on July 18, 2024

So the problem I am running into in making this change as you describe is that the other attributes are tied to Number through the cssUniqueFloat and cssUniqueMayFloat lenses. I haven't had the time to understand whether these can be decoupled from Number in a nice way.

from svg-tree.

Twinside avatar Twinside commented on July 18, 2024

I've pulled your modifications and switched back the value for opacity, and bumped the revision number. is it good for you?

from svg-tree.

kasbah avatar kasbah commented on July 18, 2024

Yes, perfect, thanks very much! The ASetter type and the Lense operators were confusing me.

from svg-tree.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.