twcable / puppet-adobe_em6 Goto Github PK

Hi Guys

The module has been working great for me (and saving huge amounts of time thanks!) so far, however I have found one minor issue and was wondering if it was something you had come across.

It works if I have a rep queue that looks like the following:

adobe_em6::instance::replication_queues:
publish:
transport_uri: 'http://ci-pub1.foobar.com:4503/bin/receive?sling:authRequestLogin=1'
serialization_type: 'binary-less'

But if I use the ampersand for binary less (s3 datastore) puppet detects the change during the agent run, and installs a new package with the correct uri, however it's not updated in AEM.

adobe_em6::instance::replication_queues:
publish:
transport_uri: 'http://cii-pub1.foobar.com:4503/bin/receive?sling:authRequestLogin=1&binaryless=true'
serialization_type: 'binary-less'

I know it's possibly more of an AEM problem, but thought there may be a way of escaping or dealing with it in the module that you had come across?
Cheers
Sam

Hi Guys

We have been using this module for some time and it works great.

One modification we have made and have been using for a while now, is to dynamically allocate Java heap based on a percentage of system ram, so we don't have to change it when upsizing and downsizing servers.

Is this something you would want to integrate into the module? Happy to provide the method, or do a pr if it's something you want.

Cheers
Sam

In file
https://github.com/TWCable/puppet-adobe_em6/blob/11026da063bf8696062eca2c814e02cdd3912649/templates/aem_type.erb

If line 26
MANAGE_COMPACTION="<%= @should_manage_compaction %>"
Evaluates to empty string
MANAGE_COMPACTION=""

It will cause line 32 if statement to fail. To get around this, the variable should be quoted to ensure it resolves to an empty string.
From
if [ ${MANAGE_COMPACTION} == "true" ]; then
To
if [ "${MANAGE_COMPACTION}" == "true" ]; then