twawszczak / amqplib-as-promised Goto Github PK

Thank you for taking the time to create this library. While I was developing a Fastify plugin utilizing this module as a dependency (fastify-amqp-async), I've noticed that ConfirmChannel exported from amqplib-as-promised/lib is of amqplib's native type instead of this module's promise-based one. Consequently, in order to import the actual promise-based ConfirmChannel, it has to be addressed like so:

import { ConfirmChannel } from 'amqplib-as-promised/lib/confirm-channel';

while all the other exported classes can be imported in the following way:

import { Channel, Connection } from 'amqplib-as-promised/lib';

While in my use case it didn't cause issues at runtime, since Connection.createChannel() returns an object with the right prototype anyway, there were some IDE type-hinting inconsistencies. I have prepared a PR with a fix.

is there a plan to update to the last version of amqlib?
I would like to use node v16 but looks like amqlib 0.5 is not compatible:

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '[email protected]',
npm WARN EBADENGINE   required: { node: '>=0.8 <=12' },
npm WARN EBADENGINE   current: { node: 'v16.13.0', npm: '8.1.0' }
npm WARN EBADENGINE }

instead of devDependancy, it says denDependancy