turnkey-commerce / gendal Goto Github PK

When updating gendal, it fails because of a renamed dependency:

$ go get -u github.com/turnkey-commerce/gendal
go get: github.com/knq/[email protected] updating to
	github.com/knq/[email protected]: parsing go.mod:
	module declares its path as: github.com/kenshaw/snaker
	        but was required as: github.com/knq/snaker

This is due to github.com/knq/snaker which changed its name to github.com/kenshaw/snaker on 2021-07-30 (7 days ago...).

I'm currently using the cockroachdb connection string against my cockroach db and during generation the foreignkey.go.tpl does not always generate all foreignkey relationship functions from the table. I have tested this on the postgres connection string against my postgres db and it works every time but going through cockroach it appears to be very random, sometimes it's generating half the foreignkey functions, sometimes 80% of them and sometimes all of them.

Anyone else using cockroachdb and getting this random behavior?

Since version 1.2.7, command line arguments are ignored when a config file is present. The following scenarios happen:

• when a config file is present and does not provide a DSN:

❯ gendal --version
error: Database DSN must be provided

❯ gendal "postgres://postgres@localhost/some_db"  [...]
error: Database DSN must be provided

• when no config file can be found, the following happens:

❯ gendal --version
config file not found, using command line arguments
gendal version 1.2.7

❯ gendal "postgres://postgres@localhost/some_db" [...]
config file not found, using command line arguments
[gendal generates according to CLI arguments]

• when a config file is present and provides a DSN:

❯ gendal --version
[gendal generates using the config file options; no CLI ouput as expected]

❯ gendal --suffix ".a_random_suffix"
[gendal generates but ignores the `suffix` option]

Hey, we would be really pleased to use #18 in our project so for now we stick to commit version 13b932a but it would be cleaner on our side to point to a specific release version number.

Do you think it's possible to release a new version of gendal containing those changes ?

Thank you very much for your work.

This schema can generate invalid code by forcing the sql.NullInt64 type for the primary key:

CREATE TABLE revinfo (
      rev INTEGER primary key
);

Originally reported by @shful on xo/xo#156.

Will be good to have an option for a configuration file (preferably TOML) that will allow the user to make the settings for a particular project rather than rely only on command line arguments. That way the generation will be more repeatable, particularly for use cases involving custom types from custom queries. Also it will be easier to support concepts of ignoring tables or white-listing tables and ensuring consistent generation over the life of a project.

gendal is still using dep.

It would be great to move to go modules.

I have the code ready and I'd be happy to submit a PR, but it is based on top of #10 and #11.
Do you prefer a PR with all 3 or shall I wait for you to merge those first.

You can have a look at the changes here.

Note: I am not fully familiar with deps/go mod yet, so any feedback is welcome.