Git Product home page Git Product logo

Comments (5)

rafzi avatar rafzi commented on August 27, 2024

@fabianpedd do we really have to use such a recent cmake version? it would be nice to stick with 3.16 which is available in ubuntu 20

from mlonmcu.

fpedd avatar fpedd commented on August 27, 2024

@rafzi I think I was using some recent feature only available in newer CMake versions. I will have a look and check if it's actually necessary. But the unit tests run just fine on the GH action machines (both on Ubuntu 18 and 20). Do they have newer CMake versions on their machines?

from mlonmcu.

PhilippvK avatar PhilippvK commented on August 27, 2024

I think there was some strange behavior where CMAKE_OBJCOPY and CMAKE_OBJECTDUMP would not be populated automatically when cross-compiling (by providing a toolchain file which sets CMAKE_C(XX)_COMPILER which was resolved by going to the latest version. However this approach was rather lazy because setting the variables manually in the toolchain file would have also worked out.

i can double check with the version of cmake installed on the chair computers by default and report if the issue still exists.

from mlonmcu.

PhilippvK avatar PhilippvK commented on August 27, 2024

Unrelated to muriscvnn:

Managing the cmake version used by MLonMCU would still be a good idea as some of the main design aspects of the project have been:

  • Reproducible end-to-end flow by freezing the used versions of the dependencies used in an environment
  • Do not mess with any software installed on the host
  • Make the usage as easy as possible e.g. do not require him to install stuff using apt-get unless necessary.

However there are also some disadvantages:

  • Increased install time PER ENVIRONMENT
  • Increased size of deps directory PER ENVIRONMENT
  • To be consistent we would also do this for the python interpreter,… where it might get tricky.

In the end we could go with a hybrid approach as also possible with all the other dependencies (riscv_gcc, tflmc,…)

  • Download an manage CMake during mlonmcu setup if cmake.exe was not provided by the user in the vars section of the environment.yml.
  • Setting cmake.exe: cmake Would then use the default system version looked up in the PATH
  • We could agree on adding this default value to the environment templates.

from mlonmcu.

PhilippvK avatar PhilippvK commented on August 27, 2024

See #97

from mlonmcu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.