Generate requirements.txt from enabled components in environment about mlonmcu HOT 10 CLOSED

@zhouxinyu0723 Is there a way where we do not have to hardcode the following lines?
https://github.com/tum-ei-eda/mlonmcu/blob/less_pip_install_issue51/mlonmcu/setup/setup.py#L191-L239
Maybe something like this could be used:

if config.name in requirements:
    ...

I can hardly think of a method to do this without hardcode because the config structures are nested.

For example how to check whether autotuning is activated?

It is also possible that certain feature names can be shared by two different modules. So I think it will be safe to check both the module name and feature name for requirements group like "tvm-autotuning" "tflite-visualization"

Then let’s keep it hardcoded as-is until we have resolved #33 which removes the nested structure of the config.

from mlonmcu.

check the branch less_pip_install_issue51.

from mlonmcu.

The command is "mlonmcu setup -g".

from mlonmcu.

First some feedback, which is not related to your implementation:

It seems like, a lot of packages are required even if ther are not used just because they are included in some mlonmcu source files such i.e.:

• tflite
• flatbuffers
• matplotlib

I will think about if we can do anything about this.

from mlonmcu.

In

https://github.com/tum-ei-eda/mlonmcu/blob/main/mlonmcu/cli/init.py#L64-L69

I initially wanted to create a MLonMCU-managed virtual environment for the user (optional), however I never bothered implementing it. With this new feature we could take care of this automatically by some degree.

from mlonmcu.

@zhouxinyu0723

The following does not work as expected when installed into an python environment (e.g. using make install):

Could you write the requirements_addition.txt to the environment directory instead?

from mlonmcu.

@zhouxinyu0723 Is there a way where we do not have to hardcode the following lines?

https://github.com/tum-ei-eda/mlonmcu/blob/less_pip_install_issue51/mlonmcu/setup/setup.py#L191-L239

Maybe something like this could be used:

if config.name in requirements:
    ...

from mlonmcu.

After adressing these comments, feel free to open a PR

from mlonmcu.

@zhouxinyu0723

The following does not work as expected when installed into an python environment (e.g. using make install):

mlonmcu/mlonmcu/setup/setup.py

Line 170 in eeb1616

output_dir = Path(__file__).parents[2] / "requirements_addition.txt"

Could you write the requirements_addition.txt to the environment directory instead?

will check it.

from mlonmcu.

@zhouxinyu0723 Is there a way where we do not have to hardcode the following lines?

https://github.com/tum-ei-eda/mlonmcu/blob/less_pip_install_issue51/mlonmcu/setup/setup.py#L191-L239

Maybe something like this could be used:

if config.name in requirements:
    ...

I doubt whether it is necessary to do it without hardcode. The problem is that the config structures are nested.

For example how to check whether autotuning is activated?

It is also possible that certain feature names can be shared by two different modules. So I think it will be safe to check both the module name and feature name for requirement groups like "tvm-autotuning" "tflite-visualization".

Then this style of naming conventions like "tvm-autotuning" need to be distinguished from "tvm". Which means branching is needed.

from mlonmcu.