Git Product home page Git Product logo

Comments (4)

reuvenharrison avatar reuvenharrison commented on May 23, 2024

Hi @petkostas,
Thanks for submitting this issue.
Before adding another configuration flag to support your request, I'd like to suggest using the Operation Tag instead of Specification Extensions to document your APIs.
What do you think?

from oasdiff.

petkostas avatar petkostas commented on May 23, 2024

Hi @reuvenharrison thanks for the suggestion, we do use the operation tags, but there are also some tools that add custom specification extensions.
Obviously, the exclude filter could take into consideration tags, the suggestion for the extension was mostly based on the fact that some other OSS tools make use of it.
In our case, the operation tag would be also a perfect candidate!

from oasdiff.

reuvenharrison avatar reuvenharrison commented on May 23, 2024

I have two follow up questions:

  1. Can you provide an example of an OSS tool that uses extensions? I'd like to make sure that I understand this.
  2. What happens if an API has an 'x-beta' extension in one of the specs only? For example:

Spec 1:

info:
  title: Tufin
  version: 1.0.0
openapi: 3.0.3
paths:
  /api/test:
    x-beta: true 
    get:
      responses:
        200:
          description: OK

Spec 2:

info:
  title: Tufin
  version: 1.0.0
openapi: 3.0.3
paths:
  /api/test:
    get:
      responses:
        200:
          description: OK

what should be the results of:
oasdiff -base spec1 -revision spec2
and:
oasdiff -base spec2 -revision spec1

from oasdiff.

petkostas avatar petkostas commented on May 23, 2024

@reuvenharrison examples of using extensions:

We are not currently using an extension to mark APIs as beta (and as you mentioned we can easily also use a tag for it), to help you understand more, we use oasdiff in our repository pipelines. every MR checks for changes against the master repo reference.
For the moment as we can't support tags or extensions, we have to manually specify which APIs are stable and additionally the ones under development. In case there is a change of the APIs under development oasdiff needs to be completely bypassed by using a commit-specific title.
I hope this makes it a bit more clear.
In your example, oasdiff would completely ignore the specific path when comparing it.

from oasdiff.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.