Git Product home page Git Product logo

Comments (2)

vsarakhan avatar vsarakhan commented on May 26, 2024 1

Hi, @reuvenharrison! Thank you so much for the quick bug fix.
I think this is a breaking change, since the API client could not set the value of an optional parameter, thinking that this variable does not affect the final output in any way, and now this variable will have a default value. For example, the request had a filtering status property (enum), but the user did not specify it and received all records in the output, and now this parameter is the default and the output of the result has changed.

from oasdiff.

reuvenharrison avatar reuvenharrison commented on May 26, 2024

Hi @vsarakhan
I fixed the problem and now the code will produce:
default value was changed from 'undefined' to '100.00'

Question:
Would you consider this a breaking-change?
As far as I understand, if the default value of a request parameter was undefined, then changing it to any specific value is not breaking.
What do you think?

from oasdiff.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.