Is your feature request related to a problem? Please describe. Wh

We could output this with a relatively small effort: <div class="snippet-clipboard

<a href="https://swagger.io/docs/specification/openapi-extensions/" rel="

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Add support for AWS API Gateway extensions to OpenAPI about oasdiff HOT 6 CLOSED

vainkop commented on June 26, 2024

Add support for AWS API Gateway extensions to OpenAPI

from oasdiff.

Comments (6)

reuvenharrison commented on June 26, 2024 2

Sure. I'm planning to do it tomorrow.

from oasdiff.

reuvenharrison commented on June 26, 2024 1

We could output this with a relatively small effort:

endpoints:
    modified:
        ?   method: POST
            path: /example/callback
        :   extensions:
                modified:
                    x-amazon-apigateway-integration:
                        from:
                            connectionId: ${vpc_link_id}
                            connectionType: VPC_LINK
                            httpMethod: POST
                            passthroughBehavior: when_no_match
                            responses:
                                default:
                                    statusCode: "200"
                            type: http_proxy
                            uri: http://api.example.com/v1/example/callback
                        to:
                            connectionId: ${vpc_link_id}
                            connectionType: VPC_LINK
                            httpMethod: POST
                            passthroughBehavior: when_no_match
                            responses:
                                default:
                                    statusCode: "200"
                            type: http_proxy
                            uri: http://api.example.com/v1/example/calllllllllback

Do you think it is good enough?

from oasdiff.

reuvenharrison commented on June 26, 2024

OpenAPI spec extensions are excluded from the diff.

Including this extension in the diff would require an enhancement.

from oasdiff.

vainkop commented on June 26, 2024

OpenAPI spec extensions are excluded from the diff.

Including this extension in the diff would require an enhancement.

That's exactly what I've tried to request :)
Currently I have to use colordiff on top of oasdiff which kind of makes oasdiff not that useful as it could be & AWS API Gateways are pretty popular.

Unfortunately I don't have enough time & Golang expertise to implement that enhancement myself :(

from oasdiff.

vainkop commented on June 26, 2024

We could output this with a relatively small effort:
Do you think it is good enough?

That's definitely better than "No changes"! :)

Of course I'd prefer to see smth like that:

 endpoints:
     modified:
         ?   method: POST
             path: /example/callback
         :   extensions:
                 modified:
                     x-amazon-apigateway-integration:
         -                 uri: http://api.example.com/v1/example/callback
         +                 uri: http://api.example.com/v1/example/calllllllllback

from oasdiff.

vainkop commented on June 26, 2024

@reuvenharrison thank you!
Any chance of adding that into a release any time soon?

from oasdiff.

Recommend Projects