tudorsirbu / librarysystem Goto Github PK

When registering a new card and inputting an email address that's already in the system, the system should just update your old registration instead of creating a new one.

At the moment, when creating a new loan, the location feature is being ignored. This should be fixed so that when creating a new loan from the eltc, the total number of items available is subtracted from the items at that location.

As an admin you should be able to see who has ever had a book.

Pressing one of the buttons labeled "Total Users", "Active Users" or "Inactive Users" the admin should get a list of only those users.

What happens:
Book counter goes up for a location when an item with the same Barcode is added to a different location.

What should happen:
A new item should be added with the selected location. It would have the same details but a different location.

Deleting a book that has been borrowed by someone makes that person's "Your Loans" page to error out because the details of the book no longer exists.

The search by barcode field should be visible if you're an admin

When adding an item, be it bulk or stand alone, you should be able to select the location of that item or bulk.

Users should be able to renew their own loan only once from their desks.
You should be able to renew only once per loan.

-Admins should be able to renew the loans of any user from that user's loans page

When looking at the item list, you should be able to see who has an item, even though there are more copies on the shelves.

When adding a new item (not bulk) there should be a field where you can specify how many copies of it you want to add.

An admin should be able to edit a user's page and edit all of their details, including their ucard number.

It seems that our users have not been getting emails for overdue items. This needs to be fixed as some of them are not aware that they have overdue books.

As an admin you should be able to see all the books that a person ever loaned.

The copies field inside -Add new item- doesn't actually add more than 1 copy.

An admin-only page where you see all the books that are on loan and who has them. The books that are overdue should be at the top.

We should facilitate logins without a scanner
ie: a menu button for manual login so that users can just input their ucard number.

Will need to think about needed security (if any)

• Maybe add a password that is only usable when using this new login form but not needed when logging in the normal way from the home screen

You need to be able to select a location, only showing the items from that location.

The admin should have a settings page where they mention what email address the end-of-week reports should go to.

This way we can make sure that if Heather leaves the ELTC or leaves the Resource Coordonator job, the new person will get the reports instead of Heather.

This is the production log that results from that error:

I, [2015-11-13T12:15:43.436750 #3373]  INFO -- : Started POST "/items" for 143.167.152.198 at 2015-11-13 12:15:43 +0000
I, [2015-11-13T12:15:43.438472 #3373]  INFO -- : Processing by ItemsController#create as HTML
I, [2015-11-13T12:15:43.438598 #3373]  INFO -- :   Parameters: {"utf8"=>"✓", "authenticity_token"=>"cBL3mydQ1sG7U5SnJydGznA1dvQEQ/ulRzrdMoD6ffeFOBxrji5whQ3kMvUiPDocKMgvl0Z3aFcmZevdrbPRjA==", "item"=>{"barcode"=>"9781305266346"}, "commit"=>"Create Item"}
D, [2015-11-13T12:15:43.441299 #3373] DEBUG -- :   Admin Load (0.5ms)  SELECT  "admins".* FROM "admins" WHERE "admins"."id" = $1  ORDER BY "admins"."id" ASC LIMIT 1  [["id", 2]]
D, [2015-11-13T12:15:43.444375 #3373] DEBUG -- :   Item Load (1.5ms)  SELECT  "items".* FROM "items" WHERE "items"."barcode" = $1 LIMIT 1  [["barcode", "9781305266346"]]
I, [2015-11-13T12:15:44.150015 #3373]  INFO -- : Completed 500 Internal Server Error in 711ms
F, [2015-11-13T12:15:44.152383 #3373] FATAL -- :
NoMethodError (undefined method `[]' for nil:NilClass):
  app/helpers/items_helper.rb:95:in `lookup_by_isbn_google'
  app/helpers/items_helper.rb:15:in `lookup_by_isbn'
  app/controllers/items_controller.rb:37:in `create'

outpan API sometimes returns the date of an item in the wrong format, ie month/day/year instead of day/month/year.
This causes the system to crash.

Search is currently fiddly, not working all the time. It also only searches for a whole string instead of separating words. Example:
If I search for "Grammar PAE" a item called "PAE Grammar" will NOT be returned. It will also NOT return a item called "Grammar for PAE"

When requesting a book, you should be able to see who has the book already

When registering a new account with an already existing email address, just update the ucard number, don't create a separate account.

An admin should have a button on either the admin control page (See #16 ) OR on their details page, only visible by an admin