[Feature Request]

装完后提示错误，如下图。是不是缺少其它依赖导致的？

OS Name: Fedora 34
Kernel：5.12.3-300.fc34.x86_64
OS type: 64bit
GNOME Shell 40.1
Windowing System: X11

is there some package i should install?

and second can you put lyrics to top bar? i would be perfection.

非常棒的GNOME shell扩展👍🏻，感谢开发者🙏🏻

但是我遇到了一点问题，我无法修改扩展中的三个颜色设置

其余功能一切正常，我使用GNOME40在Fedora34上。

During installation that extension on page gnome extensions on firefox, I opened extension configuration widow and appears this message.

The message is below:

The settings of extension desktop-lyric@tuberry had an error:

SyntaxError: expected expression, got '.'

Stack trace:

@/home/tarciano/.local/share/gnome-shell/extensions/desktop-lyric@tuberry/prefs.js:10:12
_init@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:204:33
OpenExtensionPrefsAsync/<@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:122:28
asyncCallback@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:132:13
run@resource:///org/gnome/Shell/Extensions/js/dbusService.js:175:20
main@resource:///org/gnome/Shell/Extensions/js/main.js:19:13
run@resource:///org/gnome/gjs/modules/script/package.js:222:19
start@resource:///org/gnome/gjs/modules/script/package.js:206:5
@/usr/share/gnome-shell/org.gnome.Shell.Extensions:1:17

如题。

貎似 netease-cloud-music-gtk 2.0 版本后 desktop-lyric 就不再工作了，在排查了 netease-cloud-music-gtk 的代码后没有找到原因，麻烦可以检查下看是哪里出了问题。

如图中所演示：

如题，当不想看歌词时还要到插件中心去关闭太麻烦了，如果能直接在托盘菜单中设置会更方便一些。

// extension.js

...
class DesktopLyric {
    constructor() {
        ...
        Main.overview.connectObject('showing', () => (this.view = true),
            'hiding', () => (this.view = false), this);
        ...
    }
     ...
}
...

^ For some reason, this line of code is creating an unexpected issue.

Steps to reproduce:

• Create an extension that receives showing signal

  // test1 extension.js
  
  const Main = imports.ui.main;
  
  class Extension {
      constructor() {}
  
      enable() {
    	  Main.overview.connectObject(
    		  'showing', () => log('test1 SHOWING'),
    		  'shown', () => log('test1 SHOWN'),
    		  'hiding', () => log('test1 HIDING'),
    		  'hidden', () => log('test1 HIDDEN'), this);
      }
  
      disable() {
          Main.overview.disconnectObject(this);
      }
  }
  
  function init() {
      return new Extension();
  }

• Log in with both test1 and desktop-lyric enabled, then spam Super key (or any other method to open up and close overview)

  Output from journalctl -f -o cat /usr/bin/gnome-shell:

  test1 SHOWING
  test1 SHOWN
  test1 HIDING
  test1 HIDDEN
  test1 SHOWING
  test1 SHOWN
  test1 HIDING
  test1 HIDDEN
  ...
  

• Re-enable test1, then spam Super key again

  Output from journalctl -f -o cat /usr/bin/gnome-shell:

  test1 SHOWN
  test1 HIDING
  test1 HIDDEN
  test1 SHOWN
  test1 HIDING
  test1 HIDDEN
  ...
  

  The test1 SHOWING line is clearly missing, and this affects both X11 and Wayland sessions.

With desktop-lyric disabled, I've tested out other combinations between test1 and test2 below, which didn't reproduce the same issue.

// test2 extension.js

const Main = imports.ui.main;

class Test {
	constructor() {
		Main.overview.connectObject(
			'showing', () => log('test2 SHOWING'),
			'shown', () => log('test2 SHOWN'),
			'hiding', () => log('test2 HIDING'),
			'hidden', () => log('test2 HIDDEN'), this);
	}

	destroy() {
        	Main.overview.disconnectObject(this);
	}
}

class Extension {
	constructor() {}

	enable() {
        	this._ext = new Test();
	}

	disable() {
        	this._ext.destroy();
		this._ext = null;
	}
}

function init() {
	return new Extension();
}

To be fair, no one is re-enabling extensions all the time. However GNOME will re-enable all extensions if woken up from hibernation. This issue is kinda annoying to say the least, however I couldn't locate where is actually causing the issue.

Test environments:

• kernel 6.1.12
• gnome-shell 43.3
• desktop-lyric 46a5b8f - 43c0a3f

I really recommend music match. Not to start a war here but I think downloading lyrics from a Chinese website isn't safe and especially because I'm a Taiwanese, hoping that Winnie Xi won't use phishing attacks through that webease website.

There're many software repositories update to gnome 44 but not 45, such as nixos-unstable, please consider them.