tttppp / mountain_tapir Goto Github PK

It would be useful to have a button to bulk load images into the thumbnail tray at the top. For example being able to multi-select all the photos you want at once, and then be able to place them by clicking.

The photos shouldn't be put into the actual preview pane though. The use-case is more that a user is selecting a palette, and then they want to design their collage.

The swap tool requires two clicks to swap over the images in two regions. It would be nice if the UI displayed something to show that the first click had been made (e.g. a border around the first region or if the region became shaded).

It would be nice to be able to rotate images in regions by 90 degrees.

1. Select the swap tool and highlight a region.
2. Resize the window or change the output resolution.

Expected:
3. The highlighted region stays highlighted and a further click will swap the image with another.

Actual:
3. This doesn't work at all. Further clicks seem to set the region to the first image. For some reason it also sometimes seems impossible to select a different tool.

The existing system file browser dialog is very hard to use, particularly if all the image files are numbered rather than having descriptive names. It would be nice to write a new dialog that displays thumbnails of the image files you are browsing.

For some reason when using snapcraft 2.27 the python scripts from mountain_tapir are not installed into [snap]/lib/python2.7/site-packages/mountain_tapir. This seems to have changed since snapcraft 2.26 (or possibly 2.25).

According to https://insights.ubuntu.com/2017/02/17/snapcraft-2-27-has-been-released/ there has been updates to the python plugin and it can now "detect already staged interpreter instances". I'm not sure whether that is the cause or not though.

It should be fairly easy to workaround the problem by manually updating the prime directory before snapping.

It would be good to add a default extension of ".jpg" if the user doesn't give one. I'm not actually sure what format the images are saved in if you leave the extension blank.

Release 5 (v1.0.2) fails to start with the following error:

Traceback (most recent call last):
  File "/snap/mountain-tapir/5/usr/lib/python2.7/runpy.py", line 174, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/snap/mountain-tapir/5/usr/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/snap/mountain-tapir/5/lib/python2.7/site-packages/mountain_tapir/mountain_tapir.py", line 61, in <module>
    MountainTapir(root)
  File "/snap/mountain-tapir/5/lib/python2.7/site-packages/mountain_tapir/mountain_tapir.py", line 53, in __init__
    self.recentImages = RecentImages(self.appContainer, self.controller)
  File "/snap/mountain-tapir/5/lib/python2.7/site-packages/mountain_tapir/recent_images.py", line 40, in __init__
    self.clearAllButton = TK.Button(self.recentImagesFrame, text='Clear', command=self.clearAll)
  File "/snap/mountain-tapir/5/usr/lib/python2.7/lib-tk/Tkinter.py", line 2164, in __init__
    Widget.__init__(self, master, 'button', cnf, kw)
  File "/snap/mountain-tapir/5/usr/lib/python2.7/lib-tk/Tkinter.py", line 2094, in __init__
    (widgetName, self._w) + extra + self._options(cnf))
_tkinter.TclError: failed to allocate font due to internal system font engine problem

I didn't get this when installing the snap locally with --devmode, but I do when installing the downloaded beta channel.

When comparing with the last working version (as in #20) there are plenty of files missing from the beta snap.

Currently the generated documentation mentions flake8, which seems like a good idea! We should fix the style errors.

The default max line length seems archaic, so we should aim for maybe 120 characters instead.

This could be fixed by wrapping the Python 2 and Python 3 classes for file dialogs in a new module.

See http://stackoverflow.com/a/28590707/171296 for details.

We should have a default for values from the properties file, so if it can't be found then there isn't an error.

Currently the frame button does nothing. It should create a rectangle in the middle surrounded by other rectangles. I suggest that the middle rectangle is half the width and height of the overall collage, and that the rectangles around the edge are spread roughly evenly.

If this button is pressed when there are fewer than five regions then it should revert to displaying a grid layout (or the button could be disabled?)

AFAIK, easy_install is effectively deprecated. I also had some errors due to missing tkinter and ImageTk.

Here is what worked for me on Linux Mint 20 (should also work on Ubuntu 20.04):

apt install python3-pip python3-pil.imagetk
pip3 install mountain_tapir

Thanks for your app, it works fine. :)

For example, set the canvas to 600x400 and try to generate a collage with 20 regions in it.

The program should reject generation of a collage with too many regions (as there's a minimum allowed size per region).

When switching between grid, frame and collage it would be nice to keep the same images, but to fill them (at random) into the new arrangement.

It would also be nice to do something similar when adding and removing regions, but that sounds trickier.

The clear recent images button clears all the thumbnails, but does not reset the panel to its original state. The clear button should end up in the middle of the panel, and newly loaded images should then push it to the right.

It would be good to update the properties file when a user changes a configurable property.

It would also be good to support more properties in the file too - e.g. mode, number of regions, output size.

1. Set width to 600 and height to 400, and number of regions to 10.
2. Select frame layout.

Expected:
3. A grid with 10 regions is generated.

Actual:
3. A grid with 6 regions is generated.

This happens when the perimeter happens to get divided at the very edge of the top/left/right/bottom.

This should be changed to GPL3.

It would be really useful to be able to recentre images within their rectangle. Without the ability to drag, this could be very fiddly.

Just impossible to open an images folder if outside of /home

Ubuntu 18.04

Currently the region images section grows without limit, every time you load a new image. It would be nice to add some sort of paging to this.

Orientation of photos is difficult - many existing applications display some images in different orientations. This is a placeholder ticket to investigate all the different ways in which an image can signal that it's portrait/landscape, and see which can be incorporated in Mountain Tapir.

Sometimes when swapping photos between regions, or when loading an image to replace a populated region, the preview ends up with a weird zoom on the image.

It's possible to workaround this by resizing the application window, which forces a refresh of the preview.

Click to load a new image into a region, then click cancel. There is an unsightly stack trace output.

I don't think there are any other side effects of this, but it should be quick to fix.

For some reason using snapcraft 2.26 does not build a working snap (or this might be a coincidental change - it might be a latest version of something else). When trying to load an image I get the following exception:

Exception in Tkinter callback
Traceback (most recent call last):
  File "/snap/mountain-tapir/4/usr/lib/python2.7/lib-tk/Tkinter.py", line 1540, in __call__
    return self.func(*args)
  File "mountain_tapir/controller.py", line 106, in <lambda>
    canvas.bind('<Button-1>',lambda e, c=canvas, r=region: self.clicked(c, r))
  File "mountain_tapir/controller.py", line 147, in clicked
    self.recentImages.addImage(imageFile, self.selectPlaceTool)
  File "mountain_tapir/recent_images.py", line 57, in addImage
    imageFile.makeImage('thumbnail', (THUMBNAIL_WIDTH, THUMBNAIL_HEIGHT), imageCellCanvas)
  File "mountain_tapir/image_file.py", line 48, in makeImage
    photoImage = ImageTk.PhotoImage(image)
  File "/snap/mountain-tapir/4/lib/python2.7/site-packages/PIL/ImageTk.py", line 115, in __init__
    self.paste(image)
  File "/snap/mountain-tapir/4/lib/python2.7/site-packages/PIL/ImageTk.py", line 180, in paste
    from PIL import _imagingtk
ImportError: cannot import name _imagingtk

This suggests that something is wrong with PIL. Comparing the prime directory from a working snap (v1.0.1) with a fresh build of the same code I get lots of differences. In particular:

• Changes to the handling of the desktop file including a change to the exec line and removal of the desktop line from the snap.yaml file.
• Missing python scripts from $SNAP/bin (including files named gifmaker.py and painter.py).
• Lots of changes to $SNAP/lib/python2.7/site-packages/PIL
• Pillow 4.0.0 replaced by Pillow 2.9.0.
• Missing olefile and olefile-0.44.dist-info directories.
• setuptools.34.1.1 replaced by setuptools-34.2.0.
• Changes to the mesa copyright (and maybe other files too?)

It would be nice to have images rather than text on the buttons. This should make the UI more intuitive, and also hopefully make the interface language-independent.

When increasing the number of regions we should try to keep the existing images in the collage. We should also try to do this when decreasing the number of regions, although obviously we may have to lose one of them.

The issue raised after #16 was fixed.