Git Product home page Git Product logo

Comments (6)

tsufeki avatar tsufeki commented on May 27, 2024 2

I've personally never feel the need for it (IDE is not like CI as there's no binary result, and marking any suspicious may be useful) but I see how this can be distracting - I'll put it in the next iteration.

from tenkawa-php-language-server.

crissi avatar crissi commented on May 27, 2024 1

That is unfortunate, since I am using Laravel. I also use the config from https://github.com/nunomaduro/ with phpstan vs code plugin to better match Laravel logic, but since your plugin support phpstan + other awesomeness, it would make sense me to only use that instead of phpstan vs code plugin. But right now I get way too many errors with your plugin because the neon file is not supported.

from tenkawa-php-language-server.

crissi avatar crissi commented on May 27, 2024

what about config files for phpstan, it does not seem to pick up my config: phpstan.neon, but I might be mistaking

from tenkawa-php-language-server.

tsufeki avatar tsufeki commented on May 27, 2024

Indeed, phpstan.neon is ignored, and for good reasons:

  1. Versions of phpstan used in your project and bundled in LS may be different, making config file wrong/useless.
  2. I can't include extensions "as is" - many of them rely on global state or actually load analysed code, and are therefore impossible to use in a long running process.

Phpstan levels are pretty stable in general so it may be useful to pick them from phpstan.neon, but nothing more is viable.

from tenkawa-php-language-server.

akuzia avatar akuzia commented on May 27, 2024

@tsufeki ignoreErrors and excludes_analyse are pretty viable options, in my opinion.

from tenkawa-php-language-server.

yazeed avatar yazeed commented on May 27, 2024

I agree with @crissi, your plugin would be awesome if it supported Larastan (https://github.com/nunomaduro/larastan). Maybe it's a good idea to open a separate issue for it?

from tenkawa-php-language-server.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.