Goto method definition bug when mixed type about tenkawa-php-language-server HOT 3 CLOSED

I relaxed the logic for union types in completions, go to, hovers etc . (03be2af), they should work as you expect.

But reponse()->json() will still be underlined as a warning - it'll be fixed when I integrate laravel extension (hopefully soon).

Thanks.

from tenkawa-php-language-server.

That's how union type A|B work: language server does not know if $x is actually A or actually B. Since method is only on A, it is ignored as it may be inaccessible. You need an explicit check:

/**
 * @var A|B
 */
$x = ...
if ($x instanceof A) {
    $x->test();
}

For A&B, an object can't be an instance of two unrelated classes at the same time so this type is an error. However, if B was an interface it would work:

<?php
class A
{
    public function test()
    {
    }
}

interface B
{
}

/**
 * @var A&B
 */
$x = ...
$x->test();

Tenkawa is very strict about this. I guess it could make sense to relax this behaviour a bit, but I need give it some more thought.

Anyway, thank you for reporting this. If you find any more issues, feel free to report them as well.

btw I can recommend an article Union Types vs. Intersection Types

from tenkawa-php-language-server.

Usually, Go to definition code was presented in vendor, which not override-able by this project owner.
For example, the laravel framework's response() helper method, it defines to return @return \Illuminate\Http\Response|\Illuminate\Contracts\Routing\ResponseFactory, and like i example upon this comment, the class before | does not contain json method, but after one does, when i write reponse()->json(), i think i shouldn't to check it like this:

$response = response();
if ($response instanceof \Illuminate\Contracts\Routing\ResponseFactory) {
    return $response->json(['success' => true]);
}

from tenkawa-php-language-server.