tshu-w / lit-doccano Goto Github PK

Thanks for submitting your component to Lightning Gallary. @tshu-w

That's a powerful component. There are a few points that will be nice to address before the component is added to the gallery.

1- I couldn't install the component on fresh env, seems doccano==1.8.0 conflicts with lightning

aiobotocore 2.1.2 requires botocore<1.23.25,>=1.23.24, but you have botocore 1.27.49 which is incompatible.

2- Also the dependencies should be added in the setup.py so they get installed when installing the component.

3- In the component I noticed that the username and password are hardcoded, can we improve that? maybe as inputs or using environment variables.

4- Could you add an e2e test for your example app as part of the CI ? You can get some inspiration from here: https://github.com/Lightning-AI/lightning/tree/master/tests/tests_app_examples
This is important to ensure the stability of the component :)

5- will be great to add some comments in the example app showing that this component starts a UI and how to configure the component.

If you have any questions, please reach out! we will be happy to assist you to land your component in the Lightning gallery.

cc: @zippeurfou