node helper to execute shell commands
Home Page: https://www.npmjs.com/package/exec-sh
License: MIT License
![dependabot[bot] avatar](https://avatars.githubusercontent.com/in/29110?v=4 "dependabot[bot]")
tsc -p tsconfig.json"typescript": "^4.2.3",
"exec-sh": "^0.3.5"yarn run v1.22.5
$ tsc -p tsconfig.json
node_modules/exec-sh/types/index.d.ts:6:3 - error TS1038: A 'declare' modifier cannot be used in an already ambient context.
6 declare function execSh (command: string | string[], options?: SpawnOptionsWithoutStdio | boolean, callback?: execShCallback): ChildProcessWithoutNullStreams;
~~~~~~~
node_modules/exec-sh/types/index.d.ts:7:3 - error TS1038: A 'declare' modifier cannot be used in an already ambient context.
7 declare function execSh (command: string | string[], callback?: execShCallback): ChildProcessWithoutNullStreams;
~~~~~~~
node_modules/exec-sh/types/index.d.ts:8:3 - error TS1038: A 'declare' modifier cannot be used in an already ambient context.
8 declare namespace execSh {
~~~~~~~
src/bot/commands/private/administration/exec.administration.command.ts:40:55 - error TS2559: Type 'true' has no properties in common with type 'SpawnOptionsWithoutStdio'.
40 const execCommand = await exec.promise(command, true);
~~~~
Found 4 errors.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.When used on windows this library always returns cmd even if run in a /bin/sh compatible shell. Unfortunately, not all scripts can be run in both, for example the syntax ENVVAR=value app. I am in a situation where a library is using this library in its build where it uses such syntax and fails to execute. When I manually change this library to return sh it works properly. It would be convenient if there was a env variable or property I could set to force this into a compatible mode for use in windows where a sh compatible shell is available. While I can change the value of process.platform this may have larger consequences. If this sounds worthwhile I can submit a PR.
Tests are passing in CI and locally with node 0.10 but are failing under v8.4.0.
$ npm -v
5.4.0
$ node -v
v8.4.0
$ npm test
> [email protected] test /Users/tsertkov/Projects/exec-sh
> npm run cover-test && jshint
> [email protected] cover-test /Users/tsertkov/Projects/exec-sh
> istanbul cover --dir artifacts/coverage _mocha -- --reporter spec
exec-sh
module.exports
✓ should export a single function
#execSh() arguments
✓ should pass command to spawn function
✓ should accept array of commands to run
✓ should accept true as options argument
✓ should merge defaults with options
✓ should accept optional 'callback' parameter
1) should use 'cmd /C' command prefix on windows
✓ should use 'sh -c' command prefix on *nix
✓ should return spawn() result
✓ should aggregate stdoout and stderr
✓ should catch exceptions thrown by spawn
✓ should return empty stdout and stderr when spawn throws
✓ should run callback with error when shell exit with non-zero code
12 passing (19ms)
1 failing
1) exec-sh #execSh() arguments should use 'cmd /C' command prefix on windows:
AssertionError [ERR_ASSERTION]: 'sh' === 'cmd'
at context.<anonymous> (/Users/tsertkov/Projects/exec-sh/test/exec-sh.js:98:14)
at callFn (/Users/tsertkov/Projects/exec-sh/node_modules/mocha/lib/runnable.js:250:21)
at Test.Runnable.run (/Users/tsertkov/Projects/exec-sh/node_modules/mocha/lib/runnable.js:243:7)
at Runner.runTest (/Users/tsertkov/Projects/exec-sh/node_modules/mocha/lib/runner.js:373:10)
at /Users/tsertkov/Projects/exec-sh/node_modules/mocha/lib/runner.js:451:12
at next (/Users/tsertkov/Projects/exec-sh/node_modules/mocha/lib/runner.js:298:14)
at /Users/tsertkov/Projects/exec-sh/node_modules/mocha/lib/runner.js:308:7
at next (/Users/tsertkov/Projects/exec-sh/node_modules/mocha/lib/runner.js:246:23)
at /Users/tsertkov/Projects/exec-sh/node_modules/mocha/lib/runner.js:270:7
at done (/Users/tsertkov/Projects/exec-sh/node_modules/mocha/lib/runnable.js:206:5)
at callFn (/Users/tsertkov/Projects/exec-sh/node_modules/mocha/lib/runnable.js:261:7)
at Hook.Runnable.run (/Users/tsertkov/Projects/exec-sh/node_modules/mocha/lib/runnable.js:243:7)
at next (/Users/tsertkov/Projects/exec-sh/node_modules/mocha/lib/runner.js:258:10)
at Immediate.<anonymous> (/Users/tsertkov/Projects/exec-sh/node_modules/mocha/lib/runner.js:275:5)
at runCallback (timers.js:781:20)
at tryOnImmediate (timers.js:743:5)
at processImmediate [as _immediateCallback] (timers.js:714:5)
$ npm -v
2.15.1
$ node -v
v.0.10.48
$ npm test
> [email protected] test /Users/tsertkov/Projects/exec-sh
> npm run cover-test && npm run jshint
> [email protected] cover-test /Users/tsertkov/Projects/exec-sh
> istanbul cover --dir artifacts/coverage _mocha -- --reporter spec
exec-sh
module.exports
✓ should export a single function
#execSh() arguments
✓ should pass command to spawn function
✓ should accept array of commands to run
✓ should accept true as options argument
✓ should merge defaults with options
✓ should accept optional 'callback' parameter
✓ should use 'cmd /C' command prefix on windows
✓ should use 'sh -c' command prefix on *nix
✓ should return spawn() result
✓ should aggregate stdoout and stderr
✓ should catch exceptions thrown by spawn
✓ should return empty stdout and stderr when spawn throws
✓ should run callback with error when shell exit with non-zero code
13 passing (29ms)
I just want to thank you for this great product! 4.5M weekly downloads and still only 31 stars ?! :( Much more attention should be paid to the repository by the users.
Hitting a security issue:
Prototype Pollution in merge
[email protected] requires merge@^1.2.0 via [email protected]
No patched version available for merge
Is it possible to update to latest merge?
Thanks!
Hi, I think it would be good to add TypeScript typings to this library.
Thanks
Seems like a bad idea.
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
Django
The Web framework for perfectionists with deadlines.
Laravel
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft
Open source projects and samples from Microsoft.
Google
Google ❤️ Open Source for everyone.
Alibaba
Alibaba Open Source for everyone
D3
Data-Driven Documents codes.
Tencent
China tencent open source team.