Git Product home page Git Product logo

tschipcraft / dynamiclights Goto Github PK

View Code? Open in Web Editor NEW
15.0 15.0 0.0 261 KB

Burning entities/items such as torches or lanterns emit light!

Home Page: https://tschipcraft.ddns.net/dynamiclights.html

License: Other

mcfunction 79.41% Java 20.59%
data-pack datapack dynamic dynamic-light dynamic-lights-mod lights minecraft minecraft-data-pack minecraft-data-packs minecraft-datapack minecraft-dynamic-lights server-side

dynamiclights's Introduction

๐Ÿ‘‹ Hi, Iโ€™m Tschipcraft

A Minecraft enthusiast who sometimes posts his creations online โœจ
Here you'll find all the code and resources for my Minecraft data packs, resource packs and mods.
If you have any question or suggestions don't hesitate to open an issue.
Thank you for stopping by and have a good time!


My GitHub statistics

Most Used Languages


Ko-fi button

dynamiclights's People

Contributors

tschipcraft avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

dynamiclights's Issues

Incompatible with Snapshot 24w18a (1.21)

Describe the bug

everything lights up

Steps to reproduce

1: install the datapack in a world for 24w18a (idk if the mod also does that)
2: hold/drop anything

Expected behavior

for only the stuff listed in the readme to light up

Additional context

No response

Issues with redstone

Describe the bug

Placing the light block causes block updates, triggering BUDs. This also causes cave-ins. Also, the light block isn't pushable, so players are completely unable to be pushed by pistons at feet level, making all slime elevators and bounce pads inoperable. Can you make it so the light block placement suppresses updates and light blocks are pushable?

Steps to reproduce

  1. Hold a torch

  2. Walk in front of an observer

  3. Hold a torch

  4. Step on top of an upwards-facing piston

  5. Power the piston

Expected behavior

Observers and BUDs are not triggered and players can be pushed by pistons

Additional context

No response

Incompatibility with Amethyst Golem data pack

Describe the bug

Dynamic Lights keeps sending the welcome message when installed with the Amethyst Golem data pack.

Steps to reproduce

Described above

Expected behavior

No response

Additional context

This issue could also apply to my other data packs since I use a globalised system for the menu display.

Doesn't work on server I host

Describe the bug

The mod works on single player fine but when I try to use it with a server that I host the mod doesn't run. I don't know if that just doesn't work or anything but if there's a way to make it work I would like to know.

Steps to reproduce

No response

Expected behavior

No response

Additional context

No response

I have phantom lights in my world

Describe the bug

Hi.
Hope this is the right way to report a (?) bug.

I used your dynlight mod over several months the last year, currently it is deinstalled.

Every now and then, I see phantom lights, where no lightsource should be. Probably where I dropped torches on the ground, but I can not be sure. I can see those spots on the ground, with lightlevels above 0 and no light emiting sources nearby.

I can not get rid of them, whatever I try. They appear in farms I built and it is rather annoying, because I found no way to remove them several month in.

Can you help me removing those lightsources? Is there a command to run and get rid of those phantom lights?

Thanks in advance,
John

Steps to reproduce

No response

Expected behavior

No response

Additional context

No response

Datapack triggers sculk sensors even when sneaking

Light-updates trigger sculk sensors, neglecting whether the player is sneaking or not.

Holding a torch, having equipped enchanted armor, or simply holding an enchanted tool while moving - triggers sculk sensors.

In 1.20 pre1 / RC1 no light emiting from Hand/Armour

Describe the bug

With the new 1.20 pre releases the Torches emit no light when in Hand.
On the Ground they Do.

Also the enchanted shield emits no light.

in 1.19.4 everything is fine

Steps to reproduce

get 1.20 pre1 and load the datapack

Expected behavior

No response

Additional context

No response

Shulker's Teleport when shooting

Describe the bug

Every time a shulker shoots, the shulker will teleport.

Steps to reproduce

  1. Spawn a shulker
  2. Go in Survival
  3. Get the shulker to shoot

Expected behavior

The shulker should not teleport unless it is attacked, or the block is obstructed.

Additional context

1.20.4 - Fabric
I tested with and without the mod installed and was met with different results.
I also tested the data pack and was met with the same thing.

Can overwrite existing player-placed light blocks

Describe the bug

Title says it all really, if you're playing a Minecraft map or something that has player-placed light blocks by the map builders, this will overwrite those and can remove them.

Steps to reproduce

No response

Expected behavior

Light blocks placed by players should not be touched.

Additional context

No response

More emit light level

Is your feature request related to a problem? Please describe.

The current datapack generates light levels of 6, 9, and 15. However, another users might want to use light levels other than 6, 9, and 15

Describe the feature you'd like

I attempted to add level 12 to bridge the significant gap between level 9 and level 15 but failed
It would be great to have files with a more diverse range of light levels, such as (3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15)

Describe alternatives you've considered

No response

Additional context

No response

Options to configure dynamic light sources

Is your feature request related to a problem? Please describe.

Hey there! first off, nice datapack - it works very well :)
I just had an idea for a feature:

Describe the feature you'd like

  • Option to turn of dynamic lights on a player by player basis
  • option to turn of dynamic lights for certain items (i unfortunately dont want enchanted armor to glow)

Describe alternatives you've considered

manually editing the pack could work; if i knew how :/

Additional context

No response

The pack isn't working on 1.20.6

Describe the bug

I have the datapack v1.8 installed on my purpur 1.20.6 server. It loaded successfully and there is no error, but when my player holds a torch, no dynamic light is cast. I'm not really sure how to trouble shoot better or provide more info, since as a datapack, there's no configuration, logging, or alternative way to install it. The pack shows up in /datapacks list

Steps to reproduce

Join a purpur 1.20.6 server
Hold a torch
Suffer

Expected behavior

A light block is placed while the torch is held

Additional context

No response

Incompatible with Moving Elevators mod by SuperMartijn642

Is your feature request related to a problem? Please describe.

I'm playing a friend's server with this mod enabled and I've noticed a few issues it causes with some other mods due to the nature of the generated light block. Firstly, the elevators we make with the Moving Elevators mod don't move if you're standing in them wearing enchanted armor and/or holding something that generates light; and secondly, we have the Macaw's Lights and Lamps mod and those lights get switched off if you're too close to them wearing/holding a light-generating item due to a bug with that mod.

Describe the feature you'd like

Ideally, there would be a config file wherein you could disable the dynamic lighting effects of certain blocks/items whilst keeping others intact -- for example, disabling the dynamic lighting effects of enchanted tools/items whilst leaving the effects for light-generating blocks active.

Describe alternatives you've considered

Note that Macaw will be fixing the bug in his mod to eliminate that issue; however, removing the issues with Moving Elevators has to happen via Dynamic Lighting, ideally via the aforementioned config file.

Additional context

MC 1.19.2
Forge 43.3.0

No response

Temporarily override player-placed light blocks instead of ignoring them

Is your feature request related to a problem? Please describe.

Datapack does not work on lightblocks that are already set

2024-05-05.16-31-29.mp4

Describe the feature you'd like

The datapack's light should be activated even if there is already a lightblock set there.

Describe alternatives you've considered

No response

Additional context

No response

Sculk sensors get triggert when the light gets removed

Describe the bug

When sneaking near a sculk sensor, while holding an item, that creates dynamic light in your main or off-hand, when the invisible marker entity gets removed with the /kill command, it sends out a vibration that triggers said sculk sensors in the area.

Steps to reproduce

Put a torch, lantern, etc. in your main or off-hand.
Position yourself near a sculk sensor, that detects you running around for example.
Start sneak walking near the sculk sensor.

Expected behavior

The sculk sensor should not detect the player when holding something that emmits light while sneaking.

Additional context

I wrote a quick fix that came to my mind while writing this bug report. By just teleporting the marker away before killing it no vibrations will trigger the sculk sensors near the player. I don't know if this is ideal or not. I am not very experienced when it comes to this stuff.
From the "remove_light.mcfunction" I moved the last line into a new function "kill_marker.mcfunction"
Then I added two new lines to the "remove_light.mcfunction"
execute as @s[type=minecraft:marker,tag=ts.dl.light] at @s run tp @s ~ 320 ~
function dynamiclights:internal/kill_marker

And at last I want to thank you for creating this awesome datapack.

mcfunction files.zip

Cave Air doesn't light up

Describe the bug

Working great so far, but while caving certain places don't work - started noticing it in mineshafts. I don't know how prevalent cave_air is with the new cave generation systems, but that seems to be where it fails - if I step into an area I dug out myself, it works fine.
I did look at the datapack and you have air and cave_air tagged, but in find_target.mcfunction, maybe the 'replace air' commands don't work without cave air being specified in some way, too?

Steps to reproduce

No response

Expected behavior

Lights continue following you as you move through caves.

Additional context

No response

make the light smoother

Is your feature request related to a problem? Please describe.

Hey pal ! First off, nice pack. Love it so much !

Describe the feature you'd like

i noticed that the light is not smooth
so can you add something to make the light smoother ?

Describe alternatives you've considered

No response

Additional context

No response

dosent work with voidless void trading

Describe the bug

when using voidless void trading by ianxo4 i am unable to succesfully void traid when data pack is installed however works when not installed
seems like the datapack is force loading chunks in someway

Steps to reproduce

No response

Expected behavior

No response

Additional context

No response

No work paper 1.20.4-429 please

Describe the bug

There is a Reset and an Uninstall button.
I no see this command and this datapack
My server don't work

i need so many this datapack
Please ... thanks!

Steps to reproduce

No response

Expected behavior

No response

Additional context

No response

Datapack breaks tnt duping

Describe the bug

After installing this datapack I went to use my treefarm, design by ianxofour. The tnt duper at the top of the machine destroyed itself which it never did before. I copied dupers from the wiki as well as a youtube video, still broken.

Steps to reproduce

  1. Construct these 3 dupers:

https://minecraft.wiki/w/Tutorials/Block_and_item_duplication#Piston-based_TNT_Duplication

https://www.youtube.com/watch?v=6xe4I4EqnFw&list=PLLXaW6y5zOxwDRSaTOZfIXm4myEZHhp_B&index=26&t=595s&ab_channel=ianxofour

https://www.youtube.com/watch?v=_MOFl0MmuEE&ab_channel=Kale

or use these schematics: https://www.dropbox.com/scl/fo/8pn0q6zszzsl5budlvdy7/h?rlkey=31qdp4jsa2ary1y2lqux8is65&dl=0

Expected behavior

Dupers should duplicate the tnt and let it drop. One tnt should stay with the machine to be duped again. The duped tnt at the top of the tree farm should fall and when the machine is turned off should explode at the top in the waterlogged slab without destroying the surrounding blocks.

Additional context

No response

TPS running low

Describe the bug

hello, its me again. Still love your work !!
so, i tried the 1.7 ver but its make my server tps running low. when i change it back to 1.6 ver, my tps back normal.
i dont know why its happening, can you try to do something about it ?
thank you :)

Steps to reproduce

No response

Expected behavior

No response

Additional context

No response

dosnt work with torch in hand in 1.20 ๐Ÿ’€

Describe the bug

no dynamic lights apper when torch is in hand
dropped torches work
everything else is fine

Steps to reproduce

run in 1.20

Expected behavior

torch would light up surondings

Additional context

No response

Disabled lights per player?

Is your suggested enhancement related to a problem? Please describe.

So I'm a shader user and can run pretty decent shaders and like their implementation of dynamic lights but my friends don't run modded so they don't have shaders but I want them to have dynamic lights too but whenever I'm using this the shader dynamic lights and this are both working and causing some very odd lighting.

Describe the solution you'd like

If there was someway for a client to maybe have the mod and disable some setting so that they don't see the dynamic lights that'd be great.

Describe alternatives you've considered

I've thought about just removing the mod but I really do think it would be great for my friends to have dynamic lights so I want to try making it work. I also thought about disabling the dynamic lights from the shader but they're so smooth and colored nicely that I would like to keep that if possible.

Additional context

No response

Configurable light level.

Is your feature request related to a problem? Please describe.

The light level is too high I think, I would like to be able to lower it.

Describe the feature you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

Release for minecraft 1.20.4

Is your suggested enhancement related to a problem? Please describe.

Is a 1.20.4 version being worked on? Or will you skip it to go directly to 1.21?

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

Unable to access settings menu

Describe the bug

image

Steps to reproduce

  1. run /trigger tschipcraft.menu in Minecraft 1.20.1
  2. press [Settings]

Expected behavior

No response

Additional context

No response

/trigger tschipcraft.menu

Describe the bug

After Typing /trigger tschipcraft.menu

Dynamic Light Setting won't appear.

If I use /function dynamiclights:settings

Dynamic Light Setting appears but the selections are empty.

dynamic light settings empty

Steps to reproduce

No response

Expected behavior

No response

Additional context

No response

No dynamic light is produced in 1x1 ladder space

Describe the bug

If you mine out a 1x1 space and place ladders in it to climb up/down, the space is not illuminated by dynamic light sources

Steps to reproduce

  1. Dig a 1x1 column/tunnel in the ground & place ladders along it
  2. Hold a torch or lantern or other dynamic light source in your offhand
  3. Climb up/down the ladder

Expected behavior

No response

Additional context

No response

Setting to turn off torch glow.

Is your suggested enhancement related to a problem? Please describe.

The current implementation of the hand-held torch lighting flickers as you walk. It's subtle but is bothersome, I realize this may not be fixable, but my shader already does the same thing without the flicker, so I would like to be able to turn this specific feature off.

Describe the solution you'd like

I would like a setting in the config file/menu to be able to specifically turn the hand-held torch lighting feature on and off.

Describe alternatives you've considered

No response

Additional context

No response

Add support for candles and modded torches

Is your suggested enhancement related to a problem? Please describe.

I think candles should emit light when held in hand. Also wondering if there are any plans to support items from other mods such as Bone Torch and Aquatic Torches

Describe the solution you'd like

Support for candles in all available colors and a few modded light sources

Describe alternatives you've considered

I've had a look at the wiki for supported items but I'm not too sure how exactly to do it myself. I have zero experience or familiarity with minecraft modding and java stuff. Some more information on how to do so would also be much appreciated

Additional context

No response

Unnamed markers apear where the dyanmic lights apear.

Describe the bug

Whenever I or a mob I encountered has dynamic lights, unnamed markers appear where the light comes from.
2024-01-26_22 13 26_4K

Steps to reproduce

  1. Install Axiom with dynamic lights.
  2. Play a world in creative mode.
  3. Hold out a dynamic light source or find something that produces dynamic lights.

Expected behavior

No response

Additional context

No response

Massive problems with Dynamic Lights

Describe the bug

There are actually three bugs which we had to track down. After cloning the server to a local environment, it took us days to find that Dynamic Light not just messes with TNT but also with Skulk sensors.

Please don't understand this bug report as a rant, more as a possibility to make this data pack even better and for others to find a solution to a problem, which seemingly has nothing to do with Dynamic Lights.

Our environment:
We have set up a Fabric moded server using Minecraft 1.20.1 with Fabric Loader 0.14.21 and the following mods:
08.27.23_Memory_In-Between_Modlist.txt

We are having problems with TNT blocks as it isn't possible to ignite them with a flame bow:
Flame bow 1st try:
https://www.youtube.com/watch?v=LOK2TG4cd8U

Flame bow 2nd try:
https://www.youtube.com/watch?v=VvVGtd4p1-E

But it works using Redstone

https://www.youtube.com/watch?v=Tqk7KwzZAfA

We do have problems with TNT dupers as well, which sometimes work, but fail at about 80%:
image

It's not consistent as this time, when I filmed it, most of the dupers worked correctly but some failed
https://www.youtube.com/watch?v=anO7eCW091o

As well Skulk sensors are detecting players on wool blocks:
https://www.youtube.com/watch?v=rIJYdKrTsjE

We searched high and low in every config and setting, expecting that we messed up with player rights or TNT explosions.
Somehow we stumbled over an issue here at this page and tried it out. Removing Dynamic Lights solved all problems mentioned above!

Steps to reproduce

  1. Try to ignite TNT with flame bow.
  2. Dupe TNT
  3. Move towards a Skulk Sensor on wool blocks

Expected behavior

  1. TNT explodes, breaking blocks and ignites next TNT
  2. TNT shouldn't appear on two places at the same time
  3. Skulk sensor should not detect player

Additional context

No response

Add Totem of Undying

Is your suggested enhancement related to a problem? Please describe.

Add the totem of undying to the Light emiting items.

Describe the solution you'd like

"minecraft:totem_of_undying", in 6.json

Describe alternatives you've considered

better in 3 when available

Additional context

Thx for your work on the pack. We love it!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.