true / php-punycode Goto Github PK

A Bootstring encoding of Unicode for Internationalized Domain Names in Applications (IDNA) for PHP. Actively maintained alternative can be found here: https://github.com/symfony/polyfill-intl-idn

License: MIT License

PHP 100.00%

php-punycode's Introduction

Punycode

A Bootstring encoding of Unicode for Internationalized Domain Names in Applications (IDNA).

Install

composer require true/punycode:~2.0

Usage

<?php

// Import Punycode
use TrueBV\Punycode;

$Punycode = new Punycode();
var_dump($Punycode->encode('renangonçalves.com'));
// outputs: xn--renangonalves-pgb.com

var_dump($Punycode->decode('xn--renangonalves-pgb.com'));
// outputs: renangonçalves.com

FAQ

1. What is this library for?

This library converts a Unicode encoded domain name to a IDNA ASCII form and vice-versa.

2. Why should I use this instead of PHP's IDN Functions?

If you can compile the needed dependencies (intl, libidn) there is not much difference. But if you want to write portable code between hosts (including Windows and Mac OS), or can't install PECL extensions, this is the right library for you.

php-punycode's People

Contributors

Stargazers

Watchers

php-punycode's Issues

IDNA2008 support?

If I'm not wrong, this (great) library supports the IDNA2003 specs.
What about adding support to IDNA2008 too?

Twig extension?

What about including in this repository a Twig extension for methods encode and decode?
I'm currently thinking to a couple of filters punycode_encode and punycode_decode.
Of course I can send a PR if it's interesting.

when i'm run i got this output : string(10) "tester.com"

can u explain about the error when i'm run this source i got string(10) "tester.com"
this my php version :
PHP 7.1.16 (cli) (built: Mar 28 2018 21:27:36) ( ZTS MSVC14 (Visual C++ 2015) x86 ) Copyright (c) 1997-2018 The PHP Group Zend Engine v3.1.0, Copyright (c) 1998-2018 Zend Technologies

Thank you.

Test failing with PHP 7.3

From Fedora QA
https://apps.fedoraproject.org/koschei/package/php-true-punycode?collection=f30

There was 1 failure:
1) TrueBV\PunycodeTest::testEncodeUppercase with data set #19 ('άέήίΰαβγδεζηθικλμνξοπρσστυφχ.com', 'xn--hxacdefghijklmnopqrstuvw0...2a.com')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'xn--hxacdefghijklmnopqrstuvw0caz0a1a2a.com'
+'xn--lsan50ceafgqijklmnopqrstuvwx2ca0afw3a4a.com'
/builddir/build/BUILD/php-punycode-a4d0c11a36dd7f4e7cd7096076cab6d3378a071e/tests/PunycodeTest.php:46
FAILURES!

punycode encoding does not always match up with idn_to_ascii

Hi first of thanks for making this library.

I think i found a bug:
Tried to convert : άέήίΰαβγδεζηθικλμνξοπρςστυφχ.com
Got this result from $punycode->encode($domain):
xn--hxacdefghijklmnopqrstuvwxyz0a1a2a.com

idn_to_ascii returns this result:
xn--hxacdefghijklmnopqrstuvw0caz0a1a2a.com

The backend domain registry provider we use indicates the encoded with this library as invalid punycode and the second(idn_to_ascii) as valid.

UTF-8 encoding problem

All mb_* string functions should make use of last parameter, which is encoding. Without this (at least in my case) it did not encode polish diacritical symbols encoded in utf-8 (i.e. 'gwóźdź.pl'). My suggested solution, that worked in my case, is to create private $encoding = 'utf-8' class attribute and use it in all 6 mb_something occurs along with encoding setter, just in case anyone needs different encoding. Cheers!

Cannot decode domain in uppercase

Library doesn't parse encoded domain in uppercase like XN--D1ABBGF6AIIY.XN--P1AI
However domains in uppercase form are mentioned in many places including IANA domains list http://data.iana.org/TLD/tlds-alpha-by-domain.txt

I think uppercased domains should be treated as valid as well

Abandon in favor of symfony/polyfill-intl-idn?

Follow up of #28: the symfony/polyfill-intl-idn package now implements the idn_to_ascii and idn_to_utf8 functions.

Since this repo is not maintained anymore, maybe it should be declared as abandoned here and on packagist?

PHP 8.1 deprecation warnings

PHP 8.1 throws the following deprecation warnings:

PHP Deprecated: Implicit conversion from float 0.7836734693877551 to int loses precision in /vendor/true/punycode/src/Punycode.php on line 151
PHP Deprecated: Implicit conversion from float 27.428571428571427 to int loses precision in /vendor/true/punycode/src/Punycode.php on line 145

Proposal to move to symfony/polyfill

Hi,
would you consider moving the code in this repo as a polyfill in http://github.com/symfony/polyfill/?
I didn't check how far the implementation is from idn_to_ascii and idn_to_utf8, but I'd be happy to help refactor it as a true polyfill for these functions.
WDYT?
/cc @fabpot

Undefined index notice

2019-01-23T08:25:03+00:00 NOTICE (5): Undefined index: in /var/www/html/vendor/true/punycode/src/Punycode.php on line 228

I get a few thousand of these a day, no idea what the input is that causes it though unfortunately since it's only a notice not a throwable so I can't catch it and log the input $url with the message.

In some cases wrong

xn--c.com decode, error

Wrong encoded tld

I tested a domain from this website: https://www.dnacademy.com/emoji-domains

The domain "♨️.com" should be converted to xn--j6h.com, but the output is xn--j6hy999e.com ??

Bug, incorrect if

php-punycode/src/Punycode.php

Line 83 in a4d0c11

if ($length < 1) {

if ($length < 1) but exception say what its limit when be betwen 1 and 63

Make encode/decode methos static?

I am not experienced php coder, but I guess it would be better to make these methods static.

Punicode::encode($host);

Encoding/decoding Guangdong TLD

As reported by mail:

Hello,

I have found a bug in your code https://github.com/true/php-punycode .

It can sucessfully decode xn--p1ai , but it cannot correctly decode the TLD xn--xhq521b . Did I do something wrong?

mb_internal_encoding('utf-8');
include __DIR . '/punycode.inc.php';
$punycoder = new True\Punycode();
$x = $punycoder->decode('xn--p1ai');
var_dump($x);
$x = $punycoder->decode('xn--xhq521b');
var_dump($x);

True will be a reserve word in PHP7

According to this RFC in voting phase True is to become a reserved word starting with PHP7. Which means that a namespace change should be made if we want the library to work in PHP7+