sitemaped's People

Stargazers

Watchers

sitemaped's Issues

please update for php 8.*

I meet a error when I composer update yii2-starter-kit,

"trntv/sitemaped 0.1.2 requires php ^7.1 -> your php version (8.0.13) does not satisfy that requirement."

please update it for php8.*

thanks.

TypeError in getCount after only toTxtString

Controller action code:

  public function actionSitemap()
  {
    $links = new UrlsIterator();
    $sitemap = new Sitemap(new Urlset($links));

    Yii::$app->response->format = Response::FORMAT_RAW;

    Yii::$app->response->headers->add('Content-Type', 'text/plain');
    $content = $sitemap->toTxtString();

    $linksCount = $sitemap->getCount();
    if ($linksCount > 50000) {
      Yii::warning(\sprintf('Sitemap links count is %d'), $linksCount);
    }

    return $content;
  }

Exception:

Exception 'TypeError' with message 'Argument 1 passed to DOMXPath::__construct() must be an instance of DOMDocument, null given' 

in /app/vendor/trntv/sitemaped/src/Sitemap.php:58

Stack trace:
#0 /app/vendor/trntv/sitemaped/src/Sitemap.php(58): DOMXPath->__construct(NULL)
#1 /app/landing/controllers/SiteController.php(178): Sitemaped\Sitemap->getCount()

The issue is caused by the fact that getCount() functions uses $this->document property which is not set by toTxtString() method

Proposed solution:

+    private $txtUrlCount = null;

    public function getCount(): int
    {
+        if ($this->document) {
            $xpath = new \DOMXPath($this->document);
            return $xpath->query('*/loc')->length;
+        }
+        if ($this->txtUrlCount === null) {
+            throw new \DomainException('txtUrlCount must be set');
+        }
+        return $this->txtUrlCount;
    }

    public function toTxtString($gzip = false): string
    {
        $str = '';
+       $this->txtUrlCount = 0;
        foreach ($this->root->getValue() as $url) {
            $str .= $url->loc . "\r\n";
+           $this->txtUrlCount++;
        }

        if ($gzip === true) {
            $this->ensureZlib();

            $str = \gzencode($str, $this->gzipLevel);
        }

        return $str;
    }