triniwiz / capacitor-fancy-geo Goto Github PK

Hi @triniwiz, I added this plugin to a Capacitor/Ionic project but I've been getting a couple of errors:

> Task :capacitor-fancy-geo:compileDebugJavaWithJavac FAILED
.../MVP/app-v2/node_modules/capacitor-fancy-geo/android/capacitor-fancy-geo/src/main/java/co/fitcom/capacitor/geo/Geo.java:3: error: package android.support.annotation does not exist
import android.support.annotation.Nullable;
                                 ^
.../MVP/app-v2/node_modules/capacitor-fancy-geo/android/capacitor-fancy-geo/src/main/java/co/fitcom/capacitor/geo/Geo.java:42: error: cannot access AppCompatActivity
        FancyGeo.init(getActivity().getApplication());
                                 ^
  class file for android.support.v7.app.AppCompatActivity not found
2 errors

I haven't been doing a lot of Android Native development lately but adding implementation 'com.android.support:appcompat-v7:27.0.0' here

seems to fix the issue.

Is there a way to tell my Capacitor project to use this dependency for your plugin without actually adding it to the node_modules source? Adding it fixes the issue but the next time I reinstall everything it won't be there. Or should this be part of the plugin?

I just want to ask before forking it because, as I said, it's been a while since the last time I did native Android so I could just be missing something

Please can you add a description about what does it do and for what purpose please? Looks interesting

Thank you so much

According to ionic-team/capacitor#978 (comment), this line needs to be updated

https://github.com/triniwiz/capacitor-fancy-geo/blob/master/src/android/capacitor-fancy-geo/build.gradle#L44

from
implementation 'ionic-team:capacitor-android:1+'
to
implementation project(':capacitor-android')

Or else we get DexArchiveMergerException errors