trevorhinesley / carrierwave-audio Goto Github PK

In this commit 46eb3d8#diff-df63423b67b0b8ba9b521f757b8ea475R18 the signature of the convert method was changed from def convert output_format = :mp3, output_options = {} to def convert options={}.

In the README the relevant piece of recommended code is:

 version :mp3 do
    process :convert => [:mp3]

    def full_filename(for_file)
      "#{super.chomp(File.extname(super))}.mp3"
    end
  end

Which should now be:

 version :mp3 do
    process :convert => [output_format: :mp3]

    def full_filename(for_file)
      "#{super.chomp(File.extname(super))}.mp3"
    end
  end

or an error will be raised TypeError: no implicit conversion of Symbol into Hash

Upon trying to process a conversion:

include CarrierWave::Audio
process :convert => [{output_format: :mp3}]

Rails logs this error

Sox::Error (No such file or directory - sox --type mp3...

How can I resolve this?

looks like we can't rewrite a quality of a final mp3 file and locked to 128 kbps. Is it interesting if I can create some PR with ability to set 320 kbps?

I would like to add trim and fade effects via convert processors. Looks like this does not work via output_options. Any suggestions? Thanks so far for this implementation!

It would be nice to have support for other formats, ie. wav. @tanakaworld made a fork with this function, it would be great to have it merged into master.