Git Product home page Git Product logo

repository-finder's Introduction

Getting Started

npm install

npm run start

Notes

  1. I didn't get to unit testing for this application.

  2. This application didn't implement env vars for github authentication. Based off of their docs I made the assumption that 60 requests per hour is plenty for whoever is reviewing this application.

  3. A bug I noticed is that when the app is in a mobile sized view, when the dropdown pops out it causes the page to shift slightly. Also I was running into an aria label issue on the dropdown, and I didn't get around to digging into material ui to fix these.

  4. I built this app using the REST API and planned to swap out the api function with graphql, but did not have time to dig into a lightweight graphql client, or build one myself. In the past I have used Apollo Client, but it comes with a lot more than a simple client and I would prefer not to use it with Redux.

  5. I also didn't get around to adding error states.

  6. I rushed adding in pagination last minute, and while it works I don't like my implementation very much. The fact that the search parameters state exists in 2 places is not ideal. I would have preferred to develop a better pattern to keep the leaf nodes unaware of Redux, while bringing the search parameters state to a higher level. I would not push this pattern to production.

repository-finder's People

Contributors

trentduncan avatar

Watchers

James Cloos avatar  avatar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.