traeger-gmbh / codabix-docker Goto Github PK

To reproduce:

• Start a new Codabix container in interactive mode but with --run-as-service, which means it will listen for a SIGTERM signal in order to initiate shutdown. E.g.:
  sudo docker run -it -p 8181:8181 ghcr.io/traeger-gmbh/codabix:latest --run-as-service
• In another terminal, stop the container with:
  sudo docker stop [container]

Expected behavior:

When stopping the container, Codabix should print "Codabix Engine stopping...", like this:

Codabix Engine starting (Project Directory: '/home/codabix/data', Local/Remote HTTP Port: '8181')...
Codabix Engine started.

Codabix Engine stopping...
Codabix Engine stopped.
$

Actual behavior:

Codabix doesn't appear to receive the SIGTERM signal and doesn't initiate shutdown, so the docker container is forcefully stopped after the timeout:

Codabix Engine starting (Project Directory: '/home/codabix/data', Local/Remote HTTP Port: '8181')...
Codabix Engine started.
$

According to https://stackoverflow.com/a/62245942 and https://askubuntu.com/questions/525767/what-does-an-exec-command-do#comment1847137_525787, this is because we start a .sh script (which launches codabix), so the SIGTERM isn't passed to the codabix process.
To make this work, we should use the exec command to replace the bash process with the codabix process (to that it becomes PID 1), which will allow it to receive the SIGTERM signal.