tradewright / tabcontrol-extra Goto Github PK

I'm currently using your custom control for a private software (and it is perfect by the way), but I ran into an issue dealing with the TabClosing event.
This event is currently raised after the tab is closed, instead of being raised before the tab is closed. It seems like moving the if (this.TabClosing != null) statement at the top of the OnTabClosing method (in TabControlExtra.cs) solves the issue. May you make a commit solving the problem? Thank you for your great work!

tabcontrol-extra/TabControlExtra/TabControl/TabControlExtra.cs line 238
if (this.Alignment <= TabAlignment.Bottom)
{
itemHeight = this.ItemSize.Height;
}
else
{
itemHeight = this.ItemSize.Width;
}

fix:
itemHeight = this.ItemSize.Height;

if Aligment=left and SizeMode=Fixed
rect = new Rectangle(tabStripHeight, 2, Width - tabStripHeight - 2, Height - 4)
rect .x must is this.ItemSize.Height

Hi

Firstly great project, works really well

Unless I am missing it, I can't see that it has an option to show a button to be able to add / open a new tab e.g. like a + icon or similar?

Thank you

The current version of the TabControlExtra control uses the System.Windows.Forms namespace. The original justification for doing so is that it makes it easy to substitute TabControlExtra in a program that already uses the Microsoft TabControl.

I'm uncomfortable using this namespace, as it really seems a bit of a cheek to me, although there aren't any technical problems with it. I feel that Microsoft 'owns' System.Windows.Forms, and we shouldn't really be using it for our own purposes.

So I propose a namespace change to something that fits in with the TradeWright namespace scheme. This would be something like:

TradeWright.UI.Forms

I realise this is a breaking change and would require changing some existing references or adding new using or Imports statements, but these changes are trivial (and I suspect few people are using TabControlExtra anyway).

So any reactions to this proposed change please?

The point passed to GetActiveTabIndex should be the client coordinate.
Thus the corresponding code in TabControlExtra.OnDragOver should be:

var dragPoint = new Point(drgevent.X, drgevent.Y);
var tabPoint = this.PointToScreen(Point.Empty);
dragPoint.Offset(-tabPoint.X, -tabPoint.Y);
if (this.GetActiveTab(dragPoint) == dragTab) {
    return;
}

int insertPoint = this.GetActiveIndex(dragPoint);
if (insertPoint < 0) return;

app.zip

You can add the above app.manifest file and use it in the demo project's Manifest property.
After that, it is DPI-aware.
Tab height will be automatically adjusted in various DPI settings.

Currently the size of the closer button is a constant.
I tested it and found that it could be changed to a property.

I suggest that:
If the value is positive, it is an absolute size.
If the value is negative or zero, TabControlExtra calculates rendered size = tab height - padding + TabCloserButtonSize.

Hello,

Thank you for making such a great control, it is very useful. But I would like to have a menustrip attached to it like below.

Is it possible to implement such thing or not worth to try? Can you give me suggestions please about how to do it?