Git Product home page Git Product logo

st7567_rs's Issues

Images display as black rectangles

When drawing an embedded_graphics::image::Image, all pixels within the image are set to BinaryColor::On, producing a black rectangle on screen.

Looking at the code, this seems to be from this line in lib.rs, implementing DrawTarget:

self.set_pixel(x as usize, y as usize, true);

I'm guessing for most drawing operations this works fine since they'll only try to set pixels rather than clear them, but I'm thinking Image must iterate over the whole image area, setting pixels both on and off.

I replaced this with the following and images draw correctly (lines/circles/text still work file as well):

self.set_pixel(x as usize, y as usize, color.is_on());

I'll put together a PR with that change in case it's useful (thanks for the library by the way - I've been enjoying using it!).

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.