toporin / pysatochip Goto Github PK

During a code analysis of Uniblow, I uncover that the CardConnector card_reset_seed method is buggy when one calls with a PIN of type bytes. I replaced it with: pin = list(pin)

The issue is there :

I noticed that pysatochip 0.12.3 is pinpointing specific versions of libraries in https://github.com/Toporin/pysatochip/blob/master/requirements.txt

This is causing me some headaches when Electrum ABC already has dependencies to different/newer versions of those libraries. Do you think it would be possible to replace all == by >= in the requirements, to be more future proof and cause less conflicts?

For now I'm able to work around the issue, so it is not urgent. But something to think about for future releases.
It only causes problems when I try to build a deterministic release, with all version numbers pinpointed on the Electrum ABC side as well. Then there are conflicts that I need to solve by downgrading some library versions on my end.

When I first open my satochip wallet, I get the message "Enter the pin for your None"

If I open the wallet again later in the same session, it correctly says "Enter the pin for your Satochip"

This is a very minor issue, I'm submitting it just in case you have an idea for a very simple fix. Maybe there is anything that can be done on the Electrum side to cause card_type to be defined earlier in the wallet opening process?

Or else, maybe just add a fallback in pysatochip.CardConnector:

def card_verify_PIN(self):
    logger.debug("In card_verify_PIN")
    
    while (self.card_present):
        if self.pin is None:
            is_PIN= False
            if self.client is not None:
+               card_type = self.card_type or "card"
+               msg = f'Enter the PIN for your {card_type}:'
-               msg = f'Enter the PIN for your {self.card_type}:'
                (is_PIN, pin_0)= self.client.PIN_dialog(msg) #todo: use request?