topcoderinc / va-kidney-android Goto Github PK

Blood pressure is systolic/dystolic. You need to provide a way to input 2 values and display them on graph as separate lines

On the charts screen, chart the lab values that the user has collected. The user should get a list based on this spreadsheet corresponding with the CKD stage.

The user should also have the option of showing any lab values they may choose.

The data should be read from Google Fit as appropriate.

Spreadsheet link - https://docs.google.com/spreadsheets/d/1tkpf6yZJgmODRAs1IBChXs_JjipUF7VFgzfyH-7WyL4/edit?usp=sharing

Overlapping text on charts/graph
https://onedrive.live.com/?authkey=%21AMDZ5xsjmgg9_M8&cid=64478DED9208911A&id=64478DED9208911A%212129&parId=64478DED9208911A%212127&o=OneUp

See topcoderinc/va-kidney-ios#52 for a detailed discussion

• Add a Register screen which is styled similar to Login screen
• User will enter the following fields - name, email, password, confirm password
• Store the credentials in on device database so even if user kills the app, they are able to login again into an active session

See corresponding iOS issue for more details - topcoderinc/va-kidney-ios#14

On the Chart screen, build a mechanism that allow the user to enter the various lab values obtained from their healthcare provider. This screen should focus on the lab values associated with the user's current disease stage located here.

We should store the data in Google Fit to allow secure storage and sharing among other apps.

Steps to Reproduce

1. Login as a valid user
2. Complete the profile data and click Generate Goals
3. Go to Home page
4. Click Menu > My health Profile
5. Change the name to 'Daniel Michael Blake Day-Lewis'
6. Check the header

Actual Result(s)

• Layout issue when user enters a long name

Expected Result(s)

• Must move the profile image when user enters a long name, it's position must be fixed
• After entering a long name DOB must not hidden

Frequency

• 5/5

Environment Details

• Device(s): Samsung Galaxy S5
• Operating System: Android 6.0.1
• Size: 5.1 inches (~69.6% screen-to-body ratio)
• Resolution: 1080 x 1920 pixels (~432 ppi pixel density)
• Browser(s): Chrome 64.0.3282.137

Image(s)/Video(s)/Console Log/Crash Log

As noted from previous challenge review -

FDA & USDA services should be effectively cached since they are available with rate limits. Though the rates are per hour per IP, and provide a fair amount of requests so it should likely suffice for general usage

1. use cache headers if available https://tools.ietf.org/html/rfc5861 https://tools.ietf.org/html/rfc7234
2. named ndb in code. https://ndb.nal.usda.gov/ Full name is USDA National Nutrient Database

Steps to Reproduce

1. Login as a valid user
2. Complete the profile data and click Generate Goals
3. Go to Home page
4. Click Menu > My health Profile
5. Change the name to 'Test Test'
6. Click menu and check the green bar
7. Name on the Profile/Home page are updates

Actual Result(s)

• Name on the menu is not updating once user updated the name via profile

Expected Result(s)

• Must update the name on the menu (Green section)

Frequency

• 5/5

Environment Details

• Device(s): Samsung Galaxy S5
• Operating System: Android 6.0.1
• Size: 5.1 inches (~69.6% screen-to-body ratio)
• Resolution: 1080 x 1920 pixels (~432 ppi pixel density)
• Browser(s): Chrome 64.0.3282.137

Image(s)/Video(s)/Console Log/Crash Log

app will crash if I tap on a goal item image not on the buttons

03-29 10:06:38.802 21029-21029/com.topcoder.vakidney E/AndroidRuntime: FATAL EXCEPTION: main
                                                                       Process: com.topcoder.vakidney, PID: 21029
                                                                       java.lang.RuntimeException: Unable to start activity ComponentInfo{com.topcoder.vakidney/com.topcoder.vakidney.AddNewGoalActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'int com.topcoder.vakidney.model.Goal.getTitle()' on a null object reference
                                                                           at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3253)
                                                                           at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3349)
                                                                           at android.app.ActivityThread.access$1100(ActivityThread.java:221)
                                                                           at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1794)
                                                                           at android.os.Handler.dispatchMessage(Handler.java:102)
                                                                           at android.os.Looper.loop(Looper.java:158)
                                                                           at android.app.ActivityThread.main(ActivityThread.java:7224)
                                                                           at java.lang.reflect.Method.invoke(Native Method)
                                                                           at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1230)
                                                                           at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1120)
                                                                        Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'int com.topcoder.vakidney.model.Goal.getTitle()' on a null object reference
                                                                           at com.topcoder.vakidney.AddNewGoalActivity.onCreate(AddNewGoalActivity.java:89)
                                                                           at android.app.Activity.performCreate(Activity.java:6876)
                                                                           at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1135)
                                                                           at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3206)
                                                                           at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3349) 
                                                                           at android.app.ActivityThread.access$1100(ActivityThread.java:221) 
                                                                           at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1794) 
                                                                           at android.os.Handler.dispatchMessage(Handler.java:102) 
                                                                           at android.os.Looper.loop(Looper.java:158) 
                                                                           at android.app.ActivityThread.main(ActivityThread.java:7224) 
                                                                           at java.lang.reflect.Method.invoke(Native Method) 
                                                                           at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1230) 
                                                                           at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1120) 

See topcoderinc/va-kidney-ios#61 for a detailed discussion

See https://imgur.com/a/hEHGnwW

Steps to Reproduce

1. Login as a valid user
2. Complete the profile data and click Generate Goals
3. Go to Home page
4. Click Menu > My health Profile
5. Check the green box in-front of the name field

Actual Result(s)

• No icon for the Name field

Expected Result(s)

• Must have an icon for the name field because all the others fields do have icons

Frequency

• 5/5

Environment Details

• Device(s): Samsung Galaxy S5
• Operating System: Android 6.0.1
• Size: 5.1 inches (~69.6% screen-to-body ratio)
• Resolution: 1080 x 1920 pixels (~432 ppi pixel density)
• Browser(s): Chrome 64.0.3282.137

Image(s)/Video(s)/Console Log/Crash Log

See topcoderinc/va-kidney-ios#50 for a detailed discussion of the changes needed

In the profile screen, the user should be able to enter/save the following:

• Age (Based on Date of Birth) (Health Kit if available)
• Height (Health Kit if available)
• Current Weight (Health Kit if available)
• Dialysis indicator (true or false)
• Disease Category: Stage 1, 2, 3a, 3b, 4, 5

These selections will be based on other parts of the system

• Goal setup access: Allows user to choose goals. This will be a selection from a list to be provided at a later date
• Biometric data: Allows the user to authorise the app to use Google Fit data

• Under food goals, Bowls should be Servings.
• Meat should be Oz not Pieces.
• Fluid should be Oz not Glasses
• Alcohol should be removed
• Run should be Workout and Minutes not miles.

The date of birth should have read/write from Google Fit data.

Under "My Health Profile" add the ability to add a comorbid condition and force corresponding daily measurement to the top of the home screen.

Comorbidities:

1. Hypertension
2. Diabetes mellitus
3. Congestive heart failure

If hypertension, then add OBLIGATORY daily measurement of blood pressure on HOME + add chart to follow the daily variations of BP.

If diabetes mellitus, then add OBLIGATORY daily measurement of blood glucose on HOME + add chart to follow the variation.

If congestive heart failure, then add OBLIGATORY daily body weight measurement. In patients who are not on dialysis, it must not be 3kg or higher than on previous day. Add a chart to follow the variation.

Add "Always measure either before or after going to toilet in the morning. If your weight is 3kg or higher than usual, speak to your general practitioner to adjust diuretics" on the body weight measurement screen.

See topcoderinc/va-kidney-ios#53 for a detailed discussion

1. mRecycleView is never used in any of adapters. You followed a pattern with context and parent but with parent never used there’s clearly no need to have include that reference generally (it could be rather added for a case when actually needed).

2. For view binding: you’ve removed the field-based usage, however a lot of inline bindings are still in place: http://take.ms/LFd0Y some of them right near a binder (http://take.ms/wqGiD) Ideally should be cleaned up as well.

Message from Joanne Cooke sent on 2018-05-22 20:11:22 UTC###

Not finding many changes
Could consider online group review of app st next meeting
Joanne

Sent from Joanne's iPhone

Link to HockeyApp

• https://rink.hockeyapp.net/manage/apps/739999/feedback/2282909

1. Comorbid condition measurements shouldn’t be added to goals (check iOS app). On the Home screen they work correctly (filled bar after a measurement today, show most recent one) They are making apps stop responding when tapped (from goals screen). Looks to occur when using generate goals after adding conditions

2. Unselecting a comorbid condition in profile crashes the app (after making measurements): http://take.ms/iRfQe Also looks to be related with comorbid goals added…

Please replace 'Lorem Ipsum' text with text provided in the attachment.
PseudoVet_text_replace.pdf

Since primary users are in the US, we should make the height picker in the profile for Feet/Inches. Example: 5ft 10in

Hint is not removed when a value is actually selected http://take.ms/LeSUh |  

The user will enter the following information:

• Meal type (Breakfast,Lunch,Dinner,Snack,Casual)
• Date/time of meal
• Meal items (individually)
• Item Name
• Quantity
• Unit of Measure
• [Optional] Picture of meal

The data will be stored locally on the users device and available to be referenced by other parts of the app.

On the activity screen, pull information from Google Fit:

• Distance
• Steps
• Flights Climbed

The issue is that when a person adds a meal item, they do not know which was selected from the USDA database. For example, if you enter "Chicken Noodle Soup", it's impossible to know which of the options were selected (brand, type, etc).

A better way to do this would be to search as the user is entering the food item. This way they could select the exact item they are eating.

See how the iOS app handled this

For a detailed discussion, see topcoderinc/va-kidney-ios#65

Implement it as shown in iOS app

The actual filtering results must be shown based on the chosen filters. See topcoderinc/va-kidney-ios#66 for a detailed discussion

1. There are multiple cases where there are uppercase package names(i.e CustomView, Util, Model etc), this is not a recommended standard, please can we rename them to recommended lowercase naming?

2. Classe are not properly formatted, indentation, missing whitespace etc

3. BaseAdapter is not an ideal choice for handling list data and its recommended to use RecyclerView.Adapter (especially when BaseAdapter implementation is not even using ViewHolder pattern, without ViewHolder pattern there will be performance issues that will impact in the smoothness of scrolling lists, this might get raised when used by multiple users who will start to pick up issues with lists in the App)

4. Why use an entire Third-Party library(com.makeramen:roundedimageview:2.3.0) to have a circular image, when the App already has Glide which has image transforms that can make the image circular when loading it into ImageView.

Typo: http://take.ms/GCiVo should be ‘reset’

Message from Sharon sent on 2018-07-17 18:16:44 UTC###

On my Samsung 7.0, the app icon shows up as the new picture but WAY too small. Once you download and open it up, the app is not showing on the home page or in a welcome page. IN addition the colors on the bottom of the page are not contrasted enough to read.

Link to HockeyApp

• https://rink.hockeyapp.net/manage/apps/739999/feedback/2783885

different measuring units for food. Currently on mine only g, mg, and L are listed. Most recipes will use other forms of measurement (oz, cup, etc.)

See topcoderinc/va-kidney-ios#57 for a detailed discussion

Please see topcoderinc/va-kidney-ios#64 for a detailed discussion on the changes needed for this

Steps to Reproduce

1. Login as a valid user
2. Complete the profile data and click Generate Goals
3. Go to Home page
4. Click Menu > My health Profile
5. Click Home from below menu

Actual Result(s)

• Layout issue in the workout goals progress bar when user go to the profile page and come back to the home page

Expected Result(s)

• Must not overlap the gree progress bar with the text

Frequency

• 5/5

Environment Details

• Device(s): Samsung Galaxy S5
• Operating System: Android 6.0.1
• Size: 5.1 inches (~69.6% screen-to-body ratio)
• Resolution: 1080 x 1920 pixels (~432 ppi pixel density)
• Browser(s): Chrome 64.0.3282.137

Image(s)/Video(s)/Console Log/Crash Log

Currently the food intake screen takes a comma separated list of items, but only offers a single amount and unit of measurement. This would not work for most meals as an individual may have multiple items in a single meal.

As such, we should make a "add food item" button within the intake form to allow users to continuously add food items to a meal. We should move the amount and unit fields to this new form.

On the intake form, we can change to a table or list of the items entered. Allowing a user easy ways to edit/delete items.

@KevinLeigh - As discussed, let's do the following optimisations on the Android app

• Remove unnecessary third-party libraries (i.e ButterKnife can be replaced with Android Databinding)
• Upgrade old libraries to latest version and upgrade build.gradle script
• Create recommended Build Variants for develop and production builds so that there is no need to change hardcoded values
  in build.gradle.
• Upgrade layouts to use ConstraintLayout as much as possible to increase performance by reducing nested layouts and overdraw.
• Upgrade project to use Android Architecture Components such as LiveData and ViewModel, the list of pros is quite high.
• Code should be commented consistently

As stated in title

Message from Joanne sent on 2018-07-24 17:52:10 UTC###

Can’t get logged into New app version. Could you please send password and login just to doublecheck, could just be me!

Link to HockeyApp

• https://rink.hockeyapp.net/manage/apps/739999/feedback/2885081

https://onedrive.live.com/?authkey=%21AMDZ5xsjmgg9_M8&cid=64478DED9208911A&id=64478DED9208911A%212147&parId=64478DED9208911A%212127&o=OneUp

Match size as in iOS app

Steps to Reproduce

1. Login as a valid user
2. Complete the profile data and click Generate Goals
3. Go to Home page

Actual Result(s)

• Duplicate Goals displayed in the home page [ Workout and Sodium Intake]

Expected Result(s)

• Must not display the same goals multiple times

Frequency

• 5/5

Environment Details

• Device(s): Samsung Galaxy S5
• Operating System: Android 6.0.1
• Size: 5.1 inches (~69.6% screen-to-body ratio)
• Resolution: 1080 x 1920 pixels (~432 ppi pixel density)
• Browser(s): Chrome 64.0.3282.137

Image(s)/Video(s)/Console Log/Crash Log

If I add a drug to a new meal and then delete the drug, and then save meal will crash the app

03-29 09:33:43.642 18333-18333/com.topcoder.vakidney E/AndroidRuntime: FATAL EXCEPTION: main
                                                                       Process: com.topcoder.vakidney, PID: 18333
                                                                       java.lang.ArrayIndexOutOfBoundsException: length=0; index=0
                                                                           at com.topcoder.vakidney.model.DrugInteraction.findByDrugs(DrugInteraction.java:40)
                                                                           at com.topcoder.vakidney.AddNewMealActivity$7.onClick(AddNewMealActivity.java:226)
                                                                           at android.view.View.performClick(View.java:5697)
                                                                           at android.widget.TextView.performClick(TextView.java:10826)
                                                                           at android.view.View$PerformClick.run(View.java:22526)
                                                                           at android.os.Handler.handleCallback(Handler.java:739)
                                                                           at android.os.Handler.dispatchMessage(Handler.java:95)
                                                                           at android.os.Looper.loop(Looper.java:158)
                                                                           at android.app.ActivityThread.main(ActivityThread.java:7224)
                                                                           at java.lang.reflect.Method.invoke(Native Method)
                                                                           at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1230)
                                                                           at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1120)

Steps to Reproduce

1. Login as a valid user
2. Complete the profile data and click Generate Goals
3. Go to Home page
4. Click Menu > My health Profile
5. Change the name to 'Daniel Michael Blake Day-Lewis'
6. Go to Home page and check below the 'Welcome' text

Actual Result(s)

• Long name is not displayed properly on home page

Expected Result(s)

• Must trim the name or must display only first part of the name (First name)

Frequency

• 5/5

Environment Details

• Device(s): Samsung Galaxy S5
• Operating System: Android 6.0.1
• Size: 5.1 inches (~69.6% screen-to-body ratio)
• Resolution: 1080 x 1920 pixels (~432 ppi pixel density)
• Browser(s): Chrome 64.0.3282.137

Image(s)/Video(s)/Console Log/Crash Log

It should include a pill as shown in iOS app

A user will input the medications they take, then the app will search the FDA Drug Interaction and Product Labeling Database to find interactions - https://open.fda.gov/drug/

Missing spaces: http://take.ms/qjkYz (after ‘:’ and between meal times should be ‘, ‘)

Steps to Reproduce

1. Login as a valid user
2. Complete the profile data and click Generate Goals
3. Go to Home page
4. Click Menu > My health Profile
5. Enter 2018 Aug 28 as the DOB
6. Click OK and observe

Actual Result(s)

• Can enter today's date as DOB

Expected Result(s)

• In iOS we can't choose above 2002; Must apply the same restriction here as well

Frequency

• 5/5

Environment Details

• Device(s): Samsung Galaxy S5
• Operating System: Android 6.0.1
• Size: 5.1 inches (~69.6% screen-to-body ratio)
• Resolution: 1080 x 1920 pixels (~432 ppi pixel density)
• Browser(s): Chrome 64.0.3282.137

Image(s)/Video(s)/Console Log/Crash Log