topalbu / android-binding Goto Github PK

Is there any reason to not implement it like this :

public void add(int location, T object) {
      m_array.add(location,object);
}

?

What steps will reproduce the problem?
1. add annotation to Model property: 
@Required(ErrorMessagRes = R.string.error_message)
2. call ValidationResult valRes = ModelValidator.ValidateModel(model);
3. valRes.getValidationErrors()

result is: empty instead of error_message from resource

Hello, 
I was having a look at some code, and noticed the following. Not sure it is a 
problem, but I thought it could be worth sharing:

in Observable class, in void notifyChanged() method body, there's the following 
statement:

initiators.add(this);

After that, notifyChanged(initiators) gets called i.e. the overloaded method 
notifyChanged(AbstractCollection<Object>).
Within its body, the first line is again 

initiators.add(this); 

Is this useless? Or can it give problems? Should the first one of the two calls 
be removed?

Thanks for your time

1. open wiki page at 
http://code.google.com/p/android-binding/wiki/BindableAttributes
2. see mistyped title 'Introudction', instead of 'Introduction'

Same thing below in the Index, both the text showing and its HTML anchor link.

Hi , when we used a ArrayListObservable<T> for binding, any change that we do 
in the ViewModel doesn't notify to the view. How can I notify some change in an 
ArrayListObservable?. Regards 

What steps will reproduce the problem?
1. Create an observable property in a view model : public final 
BooleanObservable myProperty = new BooleanObservable();
2. Subscribe to the observable like this :      this.myProperty.subscribe(new 
Observer(){
            public void onPropertyChanged(IObservable<?> newVal, Collection<Object> arg1) {
                Log.d("", "INVOKED");
            }           
        });
3. Bind the myProperty to an input control, like an EditText, and change the 
value often.

What is the expected output? What do you see instead?

Expected : Always being called into the subscription.
What happens : After some times, we don't get called anymore in the 
subscription. The delay vary from tests to tests.

What version of the product are you using? On what operating system?

android-binding-v30-0.5.jar, targeting android 2.2

Please provide any additional information below.

Seems to be a weak reference issues since keeping a reference to the Observer 
fix the problem :

        this.myProperty.subscribe(myPropertyObs = new Observer(){
            public void onPropertyChanged(IObservable<?> newVal, Collection<Object> arg1) {
                Log.d("", "INVOKED");
            }           
        });

Hi Folks!

Sometimes when i call "setAndBindContentView" in onCreate of an activity i get 
the following Exception.

Caused by: java.lang.NullPointerException
at gueei.binding.Observable.notifyChanged(Observable.java:52)
at gueei.binding.Observable.set(Observable.java:71)
at gueei.binding.Observable._setObject(Observable.java:79)
at 
gueei.binding.TwoWayDependentObservable.doSetValue(TwoWayDependentObservable.jav
a:25)
at gueei.binding.Observable.set(Observable.java:69)
at gueei.binding.Observable._setObject(Observable.java:79)
at gueei.binding.Attribute$Bridge.onPropertyChanged(Attribute.java:117)
at gueei.binding.Observable.notifyChanged(Observable.java:52)
at gueei.binding.Observable.notifyChanged(Observable.java:61)
at 
gueei.binding.viewAttributes.compoundButton.CheckedViewAttribute.onCheckedChange
d(CheckedViewAttribute.java:44)
at 
gueei.binding.listeners.OnCheckedChangeListenerMulticast.onCheckedChanged(OnChec
kedChangeListenerMulticast.java:20)
at android.widget.CompoundButton.setChecked(CompoundButton.java:124)
at 
gueei.binding.viewAttributes.compoundButton.CheckedViewAttribute.doSetAttributeV
alue(CheckedViewAttribute.java:34)
at gueei.binding.Attribute._setObject(Attribute.java:55)
at gueei.binding.Attribute.onBind(Attribute.java:85)
at gueei.binding.Attribute.BindTo(Attribute.java:70)
at 
gueei.binding.AttributeBinder.bindAttributeWithObservable(AttributeBinder.java:7
4)
at gueei.binding.AttributeBinder.bindView(AttributeBinder.java:57)
at gueei.binding.Binder.setAndBindContentView(Binder.java:116)

I'm not sure where this NPE comes from. Anyone knows?

Best Regards!

Stephan

So, as far as I can tell, bound Observables retain hard references to the Views 
that they are bound to. That means that when an activity is re-started (for 
example, after a screen orientation change) they are unsuitable to be reused, 
since all of the Views they are bound to will leak.  I don't have a solid 
solution to this problem, except maybe to use SoftReferences to any bound 
Views, or to somehow remove all previously bound views when bindView gets 
called on a view model a 2nd time.

Any ideas about this?

What version of the product are you using? On what operating system?
0.6

Please provide any additional information below.
I fixed it changing the following code:

http://code.google.com/p/android-binding/source/browse/branches/v0.6/AndroidBind
ingV30/src/gueei/binding/v30/app/BindingActivityV30.java?spec=svn752&r=752#131

to 

if (mBindableActionBarRef == null || mBindableActionBarRef.get() == null) 
return;

and 

http://code.google.com/p/android-binding/source/browse/branches/v0.6/AndroidBind
ingV30/src/gueei/binding/v30/app/BindingActivityV30.java?spec=svn752&r=752#136

to

if (mBindableOptionsMenuRef == null || mBindableOptionsMenuRef.get() == null ) 
return;

In all the great demo, the template of ListView is too simple.  If there is any 
embed component in the template, such as Button or CheckBox. 

I can not found a good solution to bind such embeded component with any Command.

Can you provide some suggestion?

In a ListView, I have a checkbox with OnCheckedChange even.

1. Inside the OnCheckedChange Command.
We add/remove one of the item of the source, which trigger the 
CollectionAdapter.onCollectionChanged



2. After that, because the collection.size is changed.  AndroidBinidng will do 
the re-mapping. (CollectionAdapter.getView)

3. This operation will trigger the Attribute.onPropertyChange  and it will 
cause the checkbox OnCheckedChange happen again.

Seems it is a dead lock

May I know whether it is a bug or it is as your expect?

What steps will reproduce the problem?
1. Open any resource xml file and start typing.

What is the expected output? What do you see instead?
I would like to see all the attributes associated with the Binding namespace.

What version of the product are you using? On what operating system?
22

Please provide any additional information below.

Support the scenario of binding a ViewModel to a layout and then bind a view 
(like a LinearLayout), inside the root View, to a nested field of the original 
ViewModel.

For example we have a ManViewModel with a Wife field.

class ManViewModel {
public WifeViewModel Wife;
}

Is it possible to bind a TextView like this:
...
binding:text="Wife.Name"
...

What steps will reproduce the problem?
Changing selectedPosition's value in my ViewModel.

What is the expected output? What do you see instead?
In 0.45 version I see the spinner's selected value changed. In 0.49 it always 
shows the first position.

What version of the product are you using? On what operating system?
0.49, Windows 7

Please provide any additional information below.
Like I said, my code works in 0.45 version, but not in 0.49. I submit my 
layout, activity and viewmodel as Andy Tsui suggested in the group discussions.

Reported by Martin:

> Is the spinnerTemplate working? I've tried to settled it but it always takes 
the value from itemTemplate though...

> I found what was missing... it turns out this happens when onItemSelected nor 
selectedItem aren't definen in the xml...I'd say it's a bug.

Hi, 

This is a great library, and thank you for coming up with one like this!!!

Do you have any plans to integrate or develop an IoC container (similar or 
better than http://code.google.com/p/roboguice/)?

Thanks
SK

What steps will reproduce the problem?
1. Adding a new layout in xml with android-binding schema
2. Pressing CTRL and SPACE, the content assist doesn't suggest all the possible 
keywords in android.binding schema

When i'm using the android.binding.0.4b.jar, I'm getting this error :

Error generating final archive: Found duplicate file for APK: 
AndroidManifest.xml
Origin 1: /Users/GeoVah/Projects/android_ws/GuessANumber/bin/resources.ap_
Origin 2: /Users/GeoVah/Downloads/android.binding.0.4b.jar


Updating and removing the AndroidManifest.xml from the jar seems to correct the 
problem.

This was noticed on version 0.175 (and therefore might be already fixed in 
newer versions?)

There seem to be several strange type usages throughout the API that I hope 
will get cleaned up sooner rather than later.

For example, AbstractCollection<Object> is better expressed as simply 
Collection<?>.  The reason to use Collection instead of AbstractCollection 
should be obvious.  But in addition you should usually avoid having type 
parameters of <Object> and should prefer <?>.  The reason why is easily 
demonstrated.

Given the statement: doSomething(new ArrayList<Integer>());

...the following definition of doSomething will generate an error:

public void doSomething(List<Object>);

...but the following is valid:

public void doSomething(List<?>);

In addition, one cannot cast ArrayList<Integer> to ArrayList<Object>.

If I come across other strange API signatures I'll attach them to this issue.

Is there a source ZIP download for the 0.17 release? I checked out the 0.17 
branch from svn, but it has compile errors. It doesn't seem to match exactly 
what's in the 0.17 JAR.

Thanks.

binding:onClick attribute does not work on using PojoViewModel.

version:0.49


I changed BindingSyntaxResolver, and it works fine.

See for this issue the fix on stackoverflow

http://stackoverflow.com/questions/2934185/how-to-fix-error-generating-final-arc
hive-duplicate-entry-androidmanifest-xml

Just remove the AndroidManifest.xml from your jar package

Currently, it is impossible to bind to the progress property of a SeekBar. 
While it is possible to bind to the SeekBar's current position by implementing 
a Command that binds to onSeekBarChange, it would be more natural to bind 
directly to the progress property.

1. Bind a ListView to an ArrayListObservable.
2. Make sure the view model of the list item contains a Command field.
3. In the itemTemplate, bind one of the views to the Command using 
binding:onClick.
4. Now gradually add items to the end of the array list (I added two new items 
every few seconds). While items are added, once in a while you'll see that the 
first items in the list get reordered without any reason.

I'm using v0.6 preview.

Many devices are still version 2.x. Will you add Android 2.x support?

Thanks!

[Feature request]

Make Error message of model validation organized in a hash table.

If you have a look at the notepad sample from the SDK, the listactivity enables 
to handle a specific template whem the list is empty :
http://developer.android.com/resources/tutorials/notepad/notepad-ex1.html  , 
step 4

I'm thinking it should be good to have it.

Found bug in Array Source binding, cannot support two way binding. 
Will fix in next release. 

On this page: 
http://code.google.com/p/android-binding/wiki/BindingToCursors

the Cursor is created, but it's never actually used in any code snippet. 

Maybe it could be worth to mention the setCursor method call on the 
CursorObservable, like the following: 

MusicList.setCursor(c)

Hello

I did checked out the source code using 
http://android-binding.googlecode.com/svn/trunk/ 
but I could not find *all* the recent source code. 

Then I went to check on 
http://code.google.com/p/android-binding/source/browse/?r=223#svn%2Ftrunk%2FAndr
oidBinding%2Fsrc
and some sources were actually missing.

I don't know to what trunk is actually pointing, but it is different than what 
is on latest (0.20) branch:

http://code.google.com/p/android-binding/source/browse/branches/v0.20/AndroidBin
ding/?r=223

- What steps will reproduce the problem?
   See Project Home - Project Information - Code license.
     http://code.google.com/p/android-binding/

   I hesitate to use android-binding for non-OSS because its included in apk and dex file.

   This issue already was discussed the following, but the license is not changed yet.
     https://groups.google.com/group/androidbinding/browse_thread/thread/1711f6f186b6a898

- What is the expected output? What do you see instead?
   I think good idea which to change license to like MIT License. (Andy proposed in above discussion.)

I had a look at this version of Android Binding Markup Demo.

There's a Java source file which I think it's not used at all. 
The file is: 

v0.3av07\AndroidBindingMarkupDemo\src\com\gueei\demos\markupDemo\viewModels\Cust
omView.java

Should it be removed?

Thanks

this would show the whole stacktrace for this exception. thx

What steps will reproduce the problem?
1. Setup a sample project and include android-binding project
2. Use the binding:background attribute in a layout to bind a drawable
3. Build .apk file with --rename-manifest-package aapt option. This renames the 
manifest package name, but resources will remain in the original package 
namespace.
4. Launch built apk -> no bound drawables are displayed because resource lookup 
fails because the new package name is used instead of the original one.

What is the expected output? What do you see instead?
Android Binding should be able to handle the --rename-manifest-package option. 

What version of the product are you using? On what operating system?
Android Binding 0.52 V30 / Android 4.1 and 2.3



Please provide any additional information below.
The key issue are the context.getResources().getIdentifier(..) calls in 
gueei.binding.Utility. They use the context.getPackageName() as package name 
parameter which is always the package name defined in the AndroidManifest.xml 
and not package name for R.java

I've attached a patch which allows to set the package lookup name.
It would be really nice if you could apply the patch for the next release. 
Thanks!

What steps will reproduce the problem?

1. create regular activity
2. create listview. bind the itemsource to an ArrayListObservable
   and the item to a item.xml file
3. in the item.xml file i put a imageview with a property:
binding:source:"Converters.UrlToDrawable(ScreenUrl)"

What is the expected output? What do you see instead?

Everything is fine expect that my converter called twice for each item
i have in my list.
The first call is good (with my real data) but the second call is null
and i dont need that call

What version of the product are you using? On what operating system?
android-binding-v30-0.52.jar

Please provide any additional information below.

[email protected]

thank you :)

What steps will reproduce the problem?
1.  binding:onClick="IF(editMode, saveRecord, editRecord)"

What is the expected output? What do you see instead?
Is expected that the binder selects the command to execute based on the 
conditional expression.

What version of the product are you using? On what operating system?
0.52

What steps will reproduce the problem?
1. Checkout source tree
2. Adjust various build path issues
3. Build trunk projects

What is the expected output? What do you see instead?
Description Resource    Path    Location    Type
The type CursorContentUpdate.GroupsRowModel must implement the inherited 
abstract method 
LazyLoadRowModel.isMapped() CursorContentUpdate.java    /AndroidBindingMarkupDemo/s
rc/com/gueei/demos/markupDemo/viewModels    line 59 Java Problem

Description Resource    Path    Location    Type
The type DynamicLoadingArrayList.Item must implement the inherited abstract 
method 
LazyLoadRowModel.isMapped() DynamicLoadingArrayList.java    /AndroidBindingMarkupDe
mo/src/com/gueei/demos/markupDemo/viewModels    line 66 Java Problem

Description Resource    Path    Location    Type
The type FilterCursorList.FilteredCursorRowModel must implement the inherited 
abstract method 
LazyLoadRowModel.isMapped() FilterCursorList.java   /AndroidBindingMarkupDemo/src/
com/gueei/demos/markupDemo/viewModels   line 68 Java Problem

...


Thanks!