toopher / toopher-python Goto Github PK

In Flask, the request data is an ImmutableMultiDict, so the ToopherIframe.validate method will throw an error when trying to delete the Toopher signature.

Here's how I called validate:

validated_data = api.validate(request.args, request_token)

And this is the line that threw the error:

del data['toopher_sig']

I suggest we make a mutable copy of the data that we can manipulate and return. There's probably a cleaner way to do it, but this is how I got around it in my example:

mutable_dict = {}
for key in data.keys():
    mutable_dict[key] = data[key]

The module currently builds strings using empty field name and the format method (e.g.: "We need to support {} versions of python".format("older")). We should target versions back to 2.5.

We use __getattr__ to make accessing the response data nicer, so __getattr__(self, name) returns self._raw_data[name]. However, if name isn’t in _raw_data, a KeyError will be raised. I think most Python programmers would expect an AttributeError. We should probably also support nested attributes, because auth_request.requester.id is way less pretty than auth_request.requester['id'].