toolisticon / jgiven-kotlin Goto Github PK

--

The default "expectEvent(s)" does an equals comparison of the caught events and passed expected events, which fails when values are set in the commandhandler that are not under control of the caller (generated aggregateId, generated timestamps, ...).

Idea: capture the actual events as in mockitos ArgumentCaptor and then assert manually on that list of events.

see #60

A vararg collection in my test report is rendered as Then expect events: "[Ljava.lang.Object;@5a90fcaa".

Kotlins varargs are not correctly identified as List by the core tool.

There has been an open issue and PR for years now, let's move it to this extension, and maybe one day, when jgiven supports kotlin natively, we can throw it away again.

see: https://github.com/TNG/JGiven/pull/352/files

jgiven-addons is supoerseeded and archived as a repo and should point to this repo.

also sets semVer to 1.3.0.0

Assuming this lib is stable, we used the same version as jgiven. But what if we need/want to provide new versions of this extension for the same jgiven-version?

Solution: use 4 digits. the first 3 are the used jgiven version (1.2.2), the last our "build number" for the extension.

next release would be 1.2.2.1

//

we can save 500 lines of xml and centralize core dep-management if we switch to the common parent for kotlin libs.

jgiven-kotlin has no transitive dependency to jgiven, this reuires additional dependencies in the project using this extension. We should leave this as is for the core but provide modules for spring-junit5 and junit5 to make usage of jgiven with kotlin easier ...

Imho there is no need to provide junit4 modules as well.

always fails: https://github.com/toolisticon/jgiven-kotlin/actions/runs/2710932235

This lib is pretty much feature complete ... I would couple the release version to jgiven and say: this is a 1.0.0 now.
Objections, @zambrovski ?