tonksthebear / classy-yaml Goto Github PK

When using a helper that calls yass, the current implementation of using caller.first fails to accurately fine the yaml file due to the caller being the helper class

Hey there! Congrats on your first gem! I stumbled across this gem on Twitter and thought I’d provide you a little feedback.

Having rails as a dependency is not great for a gem. Generally, it’s suggested to only include the specific parts of Rails that you actually use.

Just skimming your codebase, it seems like you only need activesupport, actionpack, and railties.

By adding rails as a whole as a dependency, you’re requiring apps to include ActiveRecord, ActionMailer, ActionMailbox, ActiveJob, ActionCable, etc as a dependency. This isn’t ideal because some apps try to cut down on their dependencies by avoiding parts of Rails that they don’t use.

Here’s an example of a Basecamp gem that extends the rails query logs to include info about the current action. Instead of requiring rails, it requires actionpack and activerecord. https://github.com/basecamp/marginalia/blob/master/marginalia.gemspec

$ ./bin/test produces

/Users/joemasilotti/.rbenv/versions/2.7.1/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:92:in `require': cannot load such file -- rails/plugin/test (LoadError)

$ rake produces

/Users/joemasilotti/workspace/forks/classy-yaml/test/dummy/config/application.rb:7:in `<top (required)>': uninitialized constant Bundler (NameError)