tomstewart89 / callback Goto Github PK

in method Signal::attach

if (_nextSlot < (Slots - 1)) {
        // Connect it up and away we go
        _connections[_nextSlot++] = slot.clone();
}

I think it must be

if (_nextSlot < Slots) {
        // Connect it up and away we go
        _connections[_nextSlot++] = slot.clone();
}

It maximizes the number of slots that Slots set

I'd like to make use of this library in some Arduino software that will be shipped as part of an ESP8266 based product, but you've not included a LICENCE.md file. Do you plan to add a licence?

Arduino Library Manager downloads versión 1.0 which uses Connect and Emit instead of Attach and Fire.

Should I use version 1.0 from the Library Manager or the GitHub's 1.1 version?

It would be great to have a specialization of the Signal template when ParameterType is void. Work-arounds such as using a dummy integer would force legacy slots to change their interfaces. I'm okay with limiting the slot parameter count to one. But I would also like to propose supporting a slot with no parameters.