tomerlichtash / mels-loop Goto Github PK

• Localized sources
• Link to glossary item standalone page

[Spec In Progress]

Feature:

• Decide on how to add images in PRs (add, integrate URLs in build and dispose)
• Integrate Cloudinary SDK in build process

e.g. /public/content/annotations/librazette-chicago-automation-show
When this is loaded in runtime, matter throws an exception, complaining about the backtick.

Parser returns the following structure for heading elements:

<h2><p>content</p></h2>

Should not use Paragraph inside Heading.

Apart from Story page, all paragraphs should have a prose-like design.
Modify line-height and font-size accordingly.

Recreate:

• Go to: https://mels-loop-nextjs.vercel.app/

• We instantiate two LocaleSeletor components.
• Each component needs locale, locales, getLocaleSymbol adn onLocaleChange
• Currently, the above props are provided via LocaleContext
• Other than onLocaleChange, these are all "passive" props.
• Currently LocaleContext is widely used for string translation purposes; LocaleSelector is the only component that's using its interactive feature.

Questions

• Should context provide such a callback as onLocaleChange, or should it be passed on?
• Should we instantiate the callback to LocaleSelector itself, thus = pass a router instance to the component?

Pros of excluding this callback from the context:

• Consistent passive approach
• No need for storing router in LocaleContext

Cons:

• As we we have two instances of the component, it means passing this callback twice:
  • Layout => TopBar => LocaleSelector
  • Layout => MobileMenu => LocaleSelector

src/components/layout/layout.tsx (65:7) @ eval

63 | setTimeout(() => {
64 | const el = window.document.getElementById(line${getLine});

65 | el.scrollIntoView(scrollProps);
| ^
66 | }, 200);
67 | }
68 | });

See: vercel/next.js#24421

Including models.ts in IPageProps where data?: any.

Opens on left on English and right on Hebrew. Should be reversed.

We need a Theme React context. The problem to solve is in on of my next PRs - when portalling the Popover, it needs to be set a Layout style with locale and theme states, just like Layout sets for the entire content on its level.

Consumers for this context: Layout and LinkSelector, which will initialize a Popover with the proper portalStyles, hooking it up with the layout by adding locale and theme types to it.

Suggested API is rather simple:

• getTheme
• setTheme

Add content and locale/theme selectors

Needs checking out for reason.

(If the result, as seen in the image, is intended, then I'd like to protest the design. I don't see the alignment with the closebox as worth the 'wrong' feel of the padded scrollbar)
I think that the padding can be limited to the space between the scrollbar and the content, so basically 0 12px 0 0 for Hebrew and 0 0 0 12px for English, or only the latter if we use dir=rtl or direction: rtl

• Allow locale selection in the popup browser. Reading the English term may be useful while staying in the containing page's locale. We can easily include the available locales in the parsed page data.
• Make the popover draggable. This will enforce a minimal titlebar which is a good solution for the closebox, currently overlapping the scrollbar, when present.

Needs editing.

• Move Resources page to articles
• Change Articles to something a bit more generic
• Move About to top level link in menu
• Change About item list to Info or something alike.

Should apply in TopBar and MobileMenu.

See codex/index.he.md in PR #61 for an example.

When run with build and start, the project is displayed correctly. It is also displayed correctly in the deployed env (see the PR).

However, when running in debug mode (yarn dev), the display of the popover is completely broken. See the attached image. The popover trigger and popover content are not styled at all.

and use popover in it?

Dark theme infrastructure is ready, but values do not match any theme yet.
Need to assign this task to UX.

Switching from Home->Docs->Blog changes the navbar layout

After playing with it a bit, I recommend the following style

    user-select: none;
    content: "※";
    left: 1px;
    position: relative;
    font-size: 0.7em;
    vertical-align: super;

First fetch of popover is slow, and seems as if Popover is opened with blank content.

Can be resolved with a preloader string ("Fetching data").

If easy enough to implement, preloader should receive the trigger's content, so we can render something like "Fetching Fortran...", to make it seems a bit more pleasing to the user.

It's there for testing

e.g. IParsedPageData

Currently used only for Story and About pages, and it holds a lot of code that concerns only Story.

I think we can move that code to Story and use mapped ContentComp implementation in Pages that need it.

Our parser doesn't understand the indirect md links, of the form [link key], later followed by
[link key]: http://...

We can either update the post-processor, or avoid such constructs. What do you think?

Bug in PR #137

Recreate

1. Open popover on REAL PROGRAMMER
2. Click on inline link FORTRAN
3. Click BACK
4. Repeat Step 2

Expected result: Back Navigation to appear
Actual result: No back navigation

To recreate try to use both em and strong inline, like so:

_*some text*_

Expected result: Bold and Italic text.
Actual result: Only italic.

Result in DOM: Nested em tags, instead of nested em and strong tags.