tomaskub / gymmealprep Goto Github PK

Create recipe layout is not readable when keyboard appears and the tips are still visible.
When tooltips are not visible and the keyboard is present they layout is sub optimal, showing both fields on a reduced area.

tooltip issue	Field size issue

The edamam parser response struct has some properties that are not optional, while the API response does not have to contain the properties. Following properties were found to be missing:

• label
• hints
• measures
  In responses to following inputs:
• "Parsley to garnish"
• "1 1/2 tsp (7.5 ml) - Extra Virgin Olive Oil (Optional)"
• "1 - whole bulb garlic"
• "Seasoning to taste"
• " 1/4 Lime, Zest "
• "½ (2g) - Dried Chilli Flakes"
• "1 - Garlic Clove, Minced"
• "3 Tbsp (42g) - Butter"

The result of missing handling of the properties are errors keyNotFound while decoding a JSON response from the server.

The recipe websites usually contain additional data, such as cooking time, preparing time, servings, etc. Currently these values still have to be added by the user. Adding parsing of these properties would improve user experience.

Updating the photo on a recipe and pressing "Done" button results in following message in the console

2023-07-08 12:28:38.442158+0200 GymMealPrep[4148:201247] [SwiftUI] Publishing changes from background threads is not allowed; make sure to publish values from the main thread (via operators like receive(on:)) on model updates. 2023-07-08 12:28:38.442321+0200 GymMealPrep[4148:201247] [SwiftUI] Publishing changes from background threads is not allowed; make sure to publish values from the main thread (via operators like receive(on:)) on model updates.

When adding a new meal to a meal plan by tapping add new meal button, and the tapping "Done" button, the new meal is not present in the detail view. After returning to meal plan list and loading in the meal plan detail view the meal is present.

The meal should be present immediately after tapping done button and returning to detail view.

Currently there is no obvious way to delete meal added to meal plan.
The user should have an easy and convenient way to remove a meal from the meal plan.

When the user decides to use the option to import recipe from web link, the app moves to screen with input, while still processing the data request and parsing the results. This leads to a situation when user is presented with yet empty fields and does not give any feedback as to what is happening. There needs to be an indication that the app is working on the request and ideally the user will not see the next screen before the data is ready to be displayed.

The recipe creator does not parse data in text fields when there are no ingredients in the ingredients text fields. However the user is not stoped from proceeding, and is not given any feedback regarding the issue.

When viewing or editing meal plan, the meals can change the order in which they appear in the list. This causes confusion in user and fails UI tests.

The meals order need to be consistent between launches.

When tag is added, the "x" button does not remove the tag from the recipe.
After reloading the recipe, the tag persists - seems like it is not a UI only problem

Currently user can add recipe from a given web link and links to images present on the side are retrieved, but they are not handled in any way.

A following feature would enhance user experience:
When user loads recipe from link, the photos present on the website are dowloaded and stored temporarily. At the last step of creating a recipe, user sees the photo is added to the recipe, and if he desires he can tap on the image, and choose any from the set of images retrieved from the recipe, or choose own image from photos library. After the user confirms the recipe creation, additional photos are disposed of, and chose photo is save with recipe data.

When entering a new meal plan creation, after taping on the add new meal and add to meal, the editor sheet dismisses itself before any action can be taken. Recording below:

RecipeCreator (adding recipe from text) allows for the user to add/change the photo of the recipe in the last view, however the button is missing any implementation.

Manipulating recipes, meal plans etc results in following error shown in console:
2023-07-08 12:52:43.327319+0200 GymMealPrep[4148:199076] [error] warning: Multiple NSEntityDescriptions claim the NSManagedObject subclass 'IngredientMO' so +entity is unable to disambiguate. CoreData: warning: Multiple NSEntityDescriptions claim the NSManagedObject subclass 'IngredientMO' so +entity is unable to disambiguate.

While typing in a new tag for the recipe the user has no feedback regarding already existing tags. While adding a tag, user should prioritize existing tags, to allow for easier grouping of the recipes. Current situation makes it difficult to ensure that a user is not adding similar tags (example: "Chicken" vs "chicken".

A good enhancement would be to add toolbar that is showing suggested tags based on the input in the text field and existing ingredients, recipe name etc.

When user is creating a recipe using the "add from text" option, and attempts to change the order of the given instructions on instruction screen, the step number is not updating. See issue recoded below:

Recording

End result screenshot

The user is able to click the "Add" button when no text is present in adjacent text field. It results in tag with no text being added to the tag list of the recipe.

The user should not be able to add an empty tag.

When entering meal plan editor, swiping left on the recipe row and tapping delete recipe is not removed from the view.