Git Product home page Git Product logo

Comments (2)

deebify avatar deebify commented on July 22, 2024

A simpler example:

SELECT id, ( a /*+b*/ + c) sum_cols
FROM my_table

the above query has a comment for +b only and because the comment is /* */ the sequence /*+ breaks the parsing.

from sqlglot.

georgesittas avatar georgesittas commented on July 22, 2024

This is out of scope for us right now. The issue is that hints are tokenized & parsed as if they were not comments:

>>> import sqlglot
>>> sqlglot.parse_one("SELECT /*+ REPARTITION(100) */ x FROM tbl")
Select(
  hint=Hint(
    expressions=[
      Anonymous(
        this=REPARTITION,
        expressions=[
          Literal(this=100, is_string=False)])]),
  expressions=[
    Column(
      this=Identifier(this=x, quoted=False))],
  from=From(
    this=Table(
      this=Identifier(this=tbl, quoted=False))))

The alternative would be to treat hints as comments, but that's brittle because comments are attached on tokens based on heuristics and there may be edge cases where hints are lost because they're attached to the wrong token.


Perhaps you can do a regex substitution in order to include a space between /* and +. This will result in tokenizing this as a comment.

from sqlglot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.