Git Product home page Git Product logo

Comments (3)

philcampeau avatar philcampeau commented on June 23, 2024

It seems that 5% shares are valued at 50% of SMP, but should be full (and 10% share should be twice SMP, but are treated as SMP).

This is correct, and seems to be a mistake in the code.

Player portfolios do not clearly indicate share holding split (5% vs 10%)

Perhaps a better approach would be to treat 5% shares as 1 cert, and the 10% shares as double certs, like the ones in 1849, 1847 AE, and a couple of others.

from 18xx.

crericha avatar crericha commented on June 23, 2024

I'm open to double certs, but I don't understand how that will help if you have two of them? How will you know? For example, if I have 10%, 5%, 5% or 10%, 10%...won't both show up as d 4?

from 18xx.

crericha avatar crericha commented on June 23, 2024

Partially fixed by #9807. The shares have the correct value now, but the sell share interface is still weird.

from 18xx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.