Comments (3)
Game sees an assign action during SR, which triggers 1817-style subsidiary rendering, which 1868 doesn't support. Assign action is showing because LHP needs to be assigned, because phase 5 triggered via train export after the OR.
The LHP assignment should definitely happen before the SR starts. Separate from that, it's not clear that SR ever needs the Assign step.
from 18xx.
The LHP assignment should definitely happen before the SR starts. Separate from that, it's not clear that SR ever needs the Assign step.
In the PR I have the assignment working during the stock round. The end-of-OR-set train export doesn't happen until next_round!
is called, so it can't happen during the operating round. Maybe I could get this to work during the BUST round which follows the OR set.
from 18xx.
On second thought, I think I will do this in the BUST round, probably would be technically better to have the LHP assignment occur before the NO BUST private anyway, and then I get OR rendering for free.
from 18xx.
Related Issues (20)
- [1862] Route includes home token, engine thinks it doesn't
- Display Name/Description of game on screen HOT 1
- There is no visible scroll thumb on the game log frame. HOT 1
- [18 India] undefined method 'pending_exchange tokens'
- [1841] Can par IRSFF at 216 in SR1 HOT 2
- [18Mag] Game does not load HOT 2
- [18USA] Allowed to bid higher than my bid power HOT 1
- [1837] Implementation List HOT 3
- [1871] Union Bank cannot par new company
- [1871] Companies are not organized according to turn order during SR HOT 1
- [System18: Poland] Game ended due to no player starting a company in SR1, but game continued to OR1.1 (minor)
- [1826] Implementation Checklist
- [1822] Tax haven bug after you view Entities or Game screen HOT 5
- 18 India - the game don't let me place the NWR token in the inicial tile of New Delhi. HOT 2
- 18India - token in OO city issue HOT 4
- [18Uruguay] - Cannot buy 7th share of a company that's over the Loan Limit
- [18Uruguay] - Phase II nationalization failed to compensate the director for his president's share HOT 1
- 18India HOT 1
- [18India] Purchase from hand amount checking is wrong
- 18India - gauge line goes away at Chennai - nevermind, another rule I missed
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from 18xx.