Comments (4)
scottredracecar
commented on September 24, 2024
@michaeljb have you noticed this in your other 1822 work? Let me know if you want me to try to reproduce. Is this the right fix for those other games (I could do that)?
from 18xx.
michaeljb
commented on September 24, 2024
@scottredracecar Yeah it shows up in the logs for other 1822 games as well. It seems fine as a fix. It's another thing to look out for when I start my 1822Base refactoring.
from 18xx.
vandamm
commented on September 24, 2024
It's not only for 22, 1817 has it too. Basically any game that uses corporation class for minors. It reproduces always and the fix is to actually use Minor class, but that breaks everything :)
from 18xx.
scottredracecar
commented on September 24, 2024
Ah, well thanks for fixing this one anyhow.
…On Wed, Aug 30, 2023 at 11:07 PM Alexander Vansach ***@***.***> wrote:
It's not only for 22, 1817 has it too. Basically any game that uses
corporation class for minors. It reproduces always and the fix is to
actually use Minor class, but that breaks everything :)
—
Reply to this email directly, view it on GitHub
<#9500 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG6CEXH4246XBZH3IMRKUZLXYASY5ANCNFSM6AAAAAA4B4QJJQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
from 18xx.
Related Issues (20)
- 18 Hiawatha - Link for Rules is broken HOT 1
- System18: Add map Northern Italy by Ian D. Wilson
- 18India player turn does not update HOT 2
- [1822CA] Montreal tile labels overlap
- [1822] Mis-calculating player value HOT 2
- [18Ardennes] Unable to issue shares after in second operating round and beyond HOT 2
- 18ESP - game id 177789 will not load HOT 3
- [1822NRS] City name misspelled
- [1860] Auto-routing doesn't use the single city bypass HOT 3
- Please close game 173881
- 1858 Swiss with Robot: buying SBB shares HOT 2
- [1822][1822MX] Will 2-player variants be added in the future? HOT 1
- [18 India] Game will not proceed HOT 1
- 18 India GIPR not allowed to place station before building tracK HOT 3
- [1862] System allows company to keep four trains in phase G and H after a late merge. HOT 1
- Add colors to games that you haven't opened and where you were pinged.
- [1849] Game can't proceed
- Show some top players' games for green hands to learn
- Feature request: profile option to suppress currency symbols
- [18ESP] "undefined method `hex_by_id' for nil" when attempting to lay down track
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from 18xx.