tobyink / p5-test-compiles Goto Github PK

Migrated from rt.cpan.org #130165 (status was 'new')

Requestors:

• [email protected] (@briandfoy)

From [email protected] (@briandfoy) on 2019-07-24 17:51:05
:

In my AppVeyor builds for PerlPowerTools using Visual Studio, the t\200-pl-file-ok-vms.t test mysteriously exits with 25.

https://ci.appveyor.com/project/briandfoy/perlpowertools/build/job/2e6903j7245qck99

Hi Toby,

First, thanks for this and all your other great tools.

I stumbled into a bit of a weed patch when using compiles on a file that included the __END__ declaration. (Same with __DATA__.) I imagine it is because by default the code is compiled into the calling package, which then interprets the token as the time to stop reading in code to compile ... but I couldn't figure out how to use the package option to work around it (mind you I was in a PIR visitor callback in a loop ...)

The following demonstrates the issue: I am sure your module functions as designed but a clarification/warning in the doc may perhaps be helpful?

use Test::More tests => 3;
use Test::Compiles;

my $code = q{
    use strict; use warnings;
    my $foo = 'bar';
};

compiles $code; # pass

$code .= q{
__DATA__
something
};

compiles $code; # fail

$code =~ s/__DATA__/__END__/;

compiles $code; # fail

Migrated from rt.cpan.org #125974 (status was 'open')

Requestors:

• [email protected]

From [email protected] on 2018-07-31 16:59:57
:

Hi,

I suspect that there's a documentation error in the Synopsis ...
compiles_ok q{ print "hello world" };
should read
compiles q{ print "hello world" };

Thanks for all those lovely modules !

"How do we convince people that in programming simplicity and clarity 'in short: what mathematicians call "elegance"' are not a dispensable luxury, but a crucial matter that decides between success and failure?"
... Edsger Wybe Dijkstra