tobi-wan-kenobi / bumblebee-status Goto Github PK

A module that shows the current status of http://jonls.dk/redshift/ (color temperature and whether it is day, night or transition).

Maybe enable activate/deactivate on click.

If the user does not provide any modules, automatically select "useful" modules based on the user's system configuration.

While I like the way themes are constructed (i.e. you have a default theme, which can be overriden by a module theme, which can be overriden by an instance theme), the structure in the code is weird and confusing.

• Passing the instance should be more straight forward, right now, the logic is distributed between modules and widgets. Maybe modules should have their own widgets derived from the general Widget class?

• The code in theme.py to determine which theme to use is also far from easy to understand and actually doesn't work correctly in certain corner cases (i.e. cycles are not possible outside the "default" path)

It is a dual monitor setup. Running it on a console shows where the problem lies. The bug seems to be related to be using python 3, since sys.maxint (line 40) is not available on python 3. Switching it to sys.maxsize seems to be the fix if I'm understanding python documentation properly (and switching it locally seems to fix the issue).

When performing a click-action on a widget that does not have an action assigned to it (i.e. clicking on the battery icon or right-clicking on the disk widget), input processing stops (probably, because an exception is thrown somewhere).

Add a module that allows a user to:

• see which screens are attached
• toggle each screen on/off (as left/rightmost screen)

Right now, each theme has 2 conceptual contents:

• Icon sets
• Colors

So, for example, we have powerline-solarized, powerline-gruvbox.

It would be nicer to have a theme that is composed of iconsets and colors. Especially for the iconsets, it could even make sense to have a "nesting" (i.e. use icons of iconset A and fallback to iconset B if icons are missing in A).

how can we set this arg:
https://github.com/tobi-wan-kenobi/bumblebee-status/blob/master/bumblebee/engine.py#L161
i need lets say, run update every minute not every second ?

Tags that contain a non-ASCII characters (umlaut, etc.) currently crash the cmus plugin and, consequently, bumblebee-status.

Make it possible to provide the module configuration also as configuration file.

Parameters on the commandline should take precedence.

Make the exclude list of the nic module a parameter (comma-separated list?)

The separator icon that's used in awesome-fonts.json doesn't exist anymore in the newer version of fontawesome

When a module is used, but dependencies are missing (executables, python modules), show an error instead of the module's content.

Hi, thanks a lot for your work :)

I tried to make this bumblebee-status works on my computer, and it appears that
it works fine except for the icons part. I have no icons at all, I tried to run the testjson.sh
script and it told me that this is not json so I assume at least a part of the problem comes
from here but I don't know what to do in order to make it work.

Thanks

Add a module that does simple ICMP RTT measurements on a configurable IP

The title, basically. This is a fairly common mistake, the python 3 uses unicode in strings by default, AFAIK, but in python 2 the developer has to specify the encoding and use string.encode()/string.decode()
Here's how the bug looks.

This is a fairly simple fix, but I am not really sure how to make pull request, sorry.

Similar code found in 2 other locations (mass = 33)

https://codeclimate.com/github/tobi-wan-kenobi/bumblebee-status/bumblebee/modules/pulseaudio.py#issue_584d46642c9bdd000100004a

Create a music player widget to show the currently playing song and some controls

Python3 doesn't have a separate exception module anymore.

RAM limits kick in when used RAM is below the given values.

The length of some modules (e.g. cmus) fluctuates quite a lot depending on the content. It would be nice to have the option to restrict the length by padding/truncating the contents.

Cyclomatic complexity is too high in method update. (8)

https://codeclimate.com/github/tobi-wan-kenobi/bumblebee-status/bumblebee/modules/pulseaudio.py#issue_5854e4620476de0001000057

i3 hangs for a ~100 ms when xrandr module is enabled

pacman.py does not do it's update in a separate thread and it freezes the bar.
I'm using Arch. So I can fix and test it.

Allow the user to specify custom button bindings for widgets via the commandline

Add rx and tx counters to the nic module to see traffic statistics.

Make it possible to list themes and modules with "-l [theme|module]", like it worked in 1.0.0

gpmdp seems to need gpmdp(obv), but also gpmdp-remote, which is not so obvious. Looking at the code, it's running commands, expecting that to be installed. Should be listed in module listings.

In the theme, allow referencing fonts/icons by their name using https://pypi.python.org/pypi/fontawesome/.

(submitted by @paxy97 )

The README says that dependencies like psutil, netifaces, and requests are not required by the core, and only required by individual modules. However, loading bumblebee-status with unrelated modules throws errors if these dependencies are not installed.

$ ./bumblebee-status -m datetime                                                                                                        
Traceback (most recent call last):
  File "./bumblebee-status", line 36, in <module>
    main()
  File "./bumblebee-status", line 18, in main
    inp=inp,
  File "/home/cjlarose/dev/bumblebee-status/bumblebee/engine.py", line 82, in __init__
    self._aliases = self._read_aliases()
  File "/home/cjlarose/dev/bumblebee-status/bumblebee/engine.py", line 119, in _read_aliases
    mod = importlib.import_module("bumblebee.modules.{}".format(module["name"]))
  File "/usr/lib/python3.6/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 978, in _gcd_import
  File "<frozen importlib._bootstrap>", line 961, in _find_and_load
  File "<frozen importlib._bootstrap>", line 950, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 655, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 205, in _call_with_frames_removed
  File "/home/cjlarose/dev/bumblebee-status/bumblebee/modules/cpu.py", line 10, in <module>
    import psutil
ModuleNotFoundError: No module named 'psutil'

This appears to be caused by the way that aliases are implemented. Aliases for modules are defined in the modules themselves, and instances of bumblebee.engine.Engine import all modules in their initializers in order to read those aliases.

Make all modules compatible with python3. That way, #!/usr/bin/env python in the main file is OK :)

The current distinction between a module, a widget, and an instance is blurry (even to me) and confusing at best (error-prone, usually).

Improve this and also find a better way to provide an interface for the modules.

• Hide alias implementation from module
• simplify callbacks and get/set by unifying (possibly with mixin)
• Add callbacks to widgets? (overhead, but nicer representation of the actual concept) - maybe make persistent widgets in the bargain
• Don't store any more state in the module, put all of it into the widget
• Widgets have "names" (which are the instances, internally) - or maybe solve that using IDs? (danger: if the IDs change, that probably causes strange timing issues when the bar gets updated during a click)

Overall goal: After this ticket is done, there should be significantly less code than before

To make bumblebee/ a pure Python directory, move themes into the root folder.

When redshift tries to automatically determine the location, invoking "redshift -p" hangs, consequently blocking the whole i3bar from updating.

Unfortunately, there's not a really easy solution to this. Probably, the best approach is to have an "asynchronous execution" command in utils that invokes a callback when it completes (i.e. decouple the i3bar update from the command update)

Cyclomatic complexity is too high in method _update_widgets. (13)

https://codeclimate.com/github/tobi-wan-kenobi/bumblebee-status/bumblebee/modules/nic.py#issue_5854ed6f8c2502000100004d

Add support for using YAML as alternative for jSON when defining templates.

Cyclomatic complexity is too high in function get_dnf_info. (15)

https://codeclimate.com/github/tobi-wan-kenobi/bumblebee-status/bumblebee/modules/dnf.py#issue_5854ed6f8c25020001000057

Add a module that displays the system load.

:(

Avoid hard-coded values in the modules. Instead, create something like a config repository. Ideally, the config parameters can come from either a configuration file or a commandline switch. That also gets rid of the incredibly ugly "splitter" hack.

For instance:

bumblebee-status -m disk time --parameter disk.path=/ --parameter time.format="%H:%M" --parameter interval=5

Or, in the config file:

interval = 5
[disk]
path=/

[time]
format = "%H:M%"

For some reason, I left out python 3.2 from the Travis tests, and I think it's because there was some issue.

i think that this commit introduced this issue: 251f8d2#diff-8cd86bca63308fc9023fb6f0117ce31eR16

output:

╰─ bumblebee-status -m kernel
Traceback (most recent call last):
  File "/usr/bin/bumblebee-status", line 64, in <module>
    main()
  File "/usr/bin/bumblebee-status", line 17, in main
    filename="{}/debug.log".format(os.path.dirname(os.path.realpath(__file__)))
  File "/usr/lib/python3.6/logging/__init__.py", line 1776, in basicConfig
    h = FileHandler(filename, mode)
  File "/usr/lib/python3.6/logging/__init__.py", line 1025, in __init__
    StreamHandler.__init__(self, self._open())
  File "/usr/lib/python3.6/logging/__init__.py", line 1054, in _open
    return open(self.baseFilename, self.mode, encoding=self.encoding)
PermissionError: [Errno 13] Permission denied: '/usr/share/bumblebee-status/debug.log'

Hi, I'm having a problem with a few of the icons not showing up. I am unable to see the icon for the time module and the pasink module. All other icons appear to have rendered correctly, and this happens with multiple different fonts.

font-awesome is installed, and the icons render correctly when I open the json file with emacs configured to use the same font.

I tried using pango:Inconsolata as I saw that's what you used in another issue.

Have you got any advice on how to troubleshoot this issue?

Finally, thanks for the tool, much appreciated. 👍

The current way of specifying events on the commandline is ugly. Improve that.

For example:

bumblebee-status --parameter disk.left_click=<command> --parameter disk.<path>.left_click=<command>

How to fix this, or at least even get rid of the triangles all together.

gruvbox theme

If I find some nice unicode icons, show weather status (clear, foggy, rain, etc.) in the bar.

Hi, is there a way to access error logs once executed in i3bar? I'm having problems with xrandr module, whenever I click on it, nothing happens and no click events work anymore on any modules. I'd like to debug that but I'm having problems figuring out how to do it. I'd appreciate some pointers.

Best
—Michal Siedlaczek

Similar code found in 2 other locations (mass = 33)

https://codeclimate.com/github/tobi-wan-kenobi/bumblebee-status/bumblebee/modules/pulseaudio.py#issue_5854e4610476de000100004c