tmck-code / pokesay Goto Github PK

I know it's kind of a silly edge case, but pokesay-windows-amd64 stalls without input (I haven't tested other builds). It appears it cannot break the loop in zone below until user manually escapes the standard input (C-z <return>), which results in the input being shown twice.

https://github.com/tmck-code/pokesay-go/blob/487afe9a85cc78f06c791c267f4fa842331844a0/cmd/pokesay.go#L38-L49

Although this is of course meant to have an input piped, I think it would be good to handle this case. In theory, we could have a more formally input handler, but that is totally overkill. Maybe documenting this would be easier...

See example below:

Hey!
I saw you are cropping the cow files a bit awkwardly since they're text files
I made this package to easily crop image files according to transparency
I think this could be useful, up to you :D
https://github.com/SHA65536/ImageShrink

So I just ran the fortune | pokesay command a few times and then this showed up without any pokemon. Notice the "choice: unown-c".

This was on macOS with version 0.5.3.

➜ fortune | pokesay
/----------------------------------------------------------------------------------\
| [A computer is] like an Old Testament god, with a lot of rules and no mercy.      |
|         -- Joseph Campbell                                                        |
\----------------------------------------------------------------------------------/
         \
          \
           \
            \
choice: unown-c / categories: [PokemonGen7xRegularUnownCCow]